Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CFE-740: Updated cert-manager-operator API to enable customization #93

Merged
merged 1 commit into from
Feb 9, 2023

Conversation

thejasn
Copy link
Contributor

@thejasn thejasn commented Jan 16, 2023

Description

Update operator API to support customization of operand deployments (controller, webhook, cainjector). This reduces end user dependency on using UnsupportedConfigOverrides which is not supported as the name indicates.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 16, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 16, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2023
@thejasn thejasn force-pushed the feature/test-apis branch 3 times, most recently from 983786d to 13a90be Compare January 25, 2023 07:27
@thejasn thejasn marked this pull request as ready for review January 25, 2023 07:28
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 25, 2023
@thejasn thejasn changed the title Updated cert-manager-operator API to enable customization CFE-740: Updated cert-manager-operator API to enable customization Jan 25, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 25, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 25, 2023

@thejasn: This pull request references CFE-740 which is a valid jira issue.

In response to this:

Description

Update operator API to support customization of operand deployments (controller, webhook, cainjector). This reduces end user dependency on using UnsupportedConfigOverrides which is not supported as the name indicates.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@thejasn
Copy link
Contributor Author

thejasn commented Jan 30, 2023

/test e2e-operator

@TrilokGeer
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 7, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thejasn, TrilokGeer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thejasn
Copy link
Contributor Author

thejasn commented Feb 7, 2023

/test e2e-operator

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 7, 2023

@thejasn: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@thejasn
Copy link
Contributor Author

thejasn commented Feb 8, 2023

/cc @xingxingxia
This will be followed up with #95, so most of the testing would need to be done as part of that.

@xingxingxia
Copy link
Contributor

Intended to review/research to do a pre-merge test before labeling. Due to no enough time currently, let me first add it:
/label qe-approved
Will test after merge.

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Feb 9, 2023
@thejasn
Copy link
Contributor Author

thejasn commented Feb 9, 2023

/label docs-approved
/label px-approved

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Feb 9, 2023
@openshift-merge-robot openshift-merge-robot merged commit df7d316 into openshift:master Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants