Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually update oc to a new version (48dcf5980a) #178

Conversation

rhmdnd
Copy link
Contributor

@rhmdnd rhmdnd commented Apr 29, 2024

This docker dependency update is failing because the version dependabot is upgrading to doesn't have a function that openshift/oc expects it to have because it was deprecated and removed.

Let's upgrade openshift/oc while we're at it so that it doesn't rely on deprecated and removed functionality of docker libraries.

This docker dependency update is failing because the version dependabot
is upgrading to doesn't have a function that openshift/oc expects it to
have because it was deprecated and removed.

Let's upgrade openshift/oc while we're at it so that it doesn't rely on
deprecated and removed functionality of docker libraries.
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2024
Copy link
Member

@mrunalp mrunalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 1, 2024
Copy link
Contributor

openshift-ci bot commented May 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrunalp, rhmdnd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 078c0f6 into openshift:dependabot/go_modules/github.com/docker/docker-24.0.9incompatible May 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants