Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webreg: remove old CSS for a sidenav that was never implemented #583

Merged
merged 1 commit into from Mar 20, 2020
Merged

webreg: remove old CSS for a sidenav that was never implemented #583

merged 1 commit into from Mar 20, 2020

Conversation

AlexNPavel
Copy link
Contributor

/cc @openshift/openshift-team-developer-productivity-platform

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 20, 2020
@AlexNPavel
Copy link
Contributor Author

Running version will be available here when it finishes building: https://server-ci-tools-583.svc.ci.openshift.org/

@AlexNPavel AlexNPavel marked this pull request as ready for review March 20, 2020 18:02
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 20, 2020
@thrasher-redhat
Copy link

I'm assuming that the tag was supposed to be for @openshift/openshift-team-developer-productivity-test-platform

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 20, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlexNPavel, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [AlexNPavel,stevekuznetsov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit f14873d into openshift:master Mar 20, 2020
@AlexNPavel
Copy link
Contributor Author

I'm assuming that the tag was supposed to be for @openshift/openshift-team-developer-productivity-test-platform

Yep. The default autocomplete that github give you when you type @testplatform if dpp's team for some reason. Looks like I chose the wrong tag this time.

@AlexNPavel AlexNPavel deleted the old-css branch March 20, 2020 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevekuznetsov stevekuznetsov stevekuznetsov approved these changes

Assignees

@stevekuznetsov stevekuznetsov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@AlexNPavel @thrasher-redhat @openshift-ci-robot @stevekuznetsov @openshift-merge-robot