Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CONSOLE-3428: blocked-edges: Declare ConsoleAvailableUpdatesNull for 4.12.1 and 4.13.0-ec.2 #3061

Merged
merged 1 commit into from Jan 27, 2023
Merged

CONSOLE-3428: blocked-edges: Declare ConsoleAvailableUpdatesNull for 4.12.1 and 4.13.0-ec.2 #3061

merged 1 commit into from Jan 27, 2023

Conversation

wking
Copy link
Member

@wking wking commented Jan 26, 2023

No description provided.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 26, 2023
@LalatenduMohanty
Copy link
Member

LalatenduMohanty commented Jan 27, 2023 •
edited

/hold To give the respective bug owner some time to answer impact assessment questions.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 27, 2023
@wking wking force-pushed the console-availableUpdates-null-crash branch from aa9e88f to 6bc4770 Compare January 27, 2023 03:30
@wking wking changed the title blocked-edges: Declare ConsoleAvailableUpdatesNull for 4.12.1 and 4.13.0-ec.2 CONSOLE-3428: blocked-edges: Declare ConsoleAvailableUpdatesNull for 4.12.1 and 4.13.0-ec.2 Jan 27, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 27, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 27, 2023 •
edited by openshift-ci bot

@wking: This pull request references CONSOLE-3428 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking wking force-pushed the console-availableUpdates-null-crash branch from 6bc4770 to 5bb1481 Compare January 27, 2023 17:46
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 27, 2023

@wking: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

petr-muller
petr-muller approved these changes Jan 27, 2023
View reviewed changes
Copy link
Member

@petr-muller petr-muller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

LGTM, merge as needed

@LalatenduMohanty
Copy link
Member

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 27, 2023
LalatenduMohanty
LalatenduMohanty approved these changes Jan 27, 2023
View reviewed changes
Copy link
Member

@LalatenduMohanty LalatenduMohanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LalatenduMohanty, petr-muller, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [LalatenduMohanty,petr-muller,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 4e18358 into openshift:master Jan 27, 2023
@wking wking deleted the console-availableUpdates-null-crash branch January 27, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petr-muller petr-muller petr-muller approved these changes

@LalatenduMohanty LalatenduMohanty LalatenduMohanty approved these changes

@PratikMahajan PratikMahajan Awaiting requested review from PratikMahajan

Assignees

@LalatenduMohanty LalatenduMohanty

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
5 participants
@wking @LalatenduMohanty @openshift-ci-robot @petr-muller @openshift-merge-robot