Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove KubeletRestartBug risk #3792

Merged

Conversation

sdodson
Copy link
Member

@sdodson sdodson commented Jun 30, 2023

While this is a definite regression there are no normally supported operations which trigger a kubelet restart outside of a drain and reboot cycle. Additionally, the risk is simply that pods get restarted which is an expected pod lifecycle event which workloads must tolerate due to any number of conditions such as eviction policies. Therefore we are removing this risk, we hope that a fix for this defect will be available soon.

We recommend continuing to follow this bug for progress https://issues.redhat.com/browse/OCPBUGS-14605

While this is a definite regression there are no normally supported
operations which trigger a kubelet restart outside of a drain and reboot
cycle. Additionally, the risk is simply that pods get restarted which is
an expected pod lifecycle event which workloads must tolerate due to any
number of conditions such as eviction policies. Therefore we are removing
this risk, we hope that a fix for this defect will be available soon.

We recommend continuing to follow this bug for progress
https://issues.redhat.com/browse/OCPBUGS-14605
@sdodson
Copy link
Member Author

sdodson commented Jun 30, 2023

/hold
Just looking to confirm that the current UX due to multiple PromQL evaluations is still confusing. Test cluster coming up now.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 30, 2023
@sdodson
Copy link
Member Author

sdodson commented Jun 30, 2023

Confirmed that a 4.12.20 cluster switching to 4.13 channel doesn't complete evaluating conditional risks for 10 minutes or longer.

@sdodson
Copy link
Member Author

sdodson commented Jun 30, 2023

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 30, 2023
@sdodson sdodson added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Jun 30, 2023
@sdodson
Copy link
Member Author

sdodson commented Jun 30, 2023

/test e2e

Copy link
Member

@wking wking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sdodson, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 30, 2023

@sdodson: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit a7bdd70 into openshift:master Jun 30, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
3 participants