-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove KubeletRestartBug risk #3792
Remove KubeletRestartBug risk #3792
Conversation
While this is a definite regression there are no normally supported operations which trigger a kubelet restart outside of a drain and reboot cycle. Additionally, the risk is simply that pods get restarted which is an expected pod lifecycle event which workloads must tolerate due to any number of conditions such as eviction policies. Therefore we are removing this risk, we hope that a fix for this defect will be available soon. We recommend continuing to follow this bug for progress https://issues.redhat.com/browse/OCPBUGS-14605
/hold |
Confirmed that a 4.12.20 cluster switching to 4.13 channel doesn't complete evaluating conditional risks for 10 minutes or longer. |
/hold cancel |
/test e2e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sdodson, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@sdodson: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
While this is a definite regression there are no normally supported operations which trigger a kubelet restart outside of a drain and reboot cycle. Additionally, the risk is simply that pods get restarted which is an expected pod lifecycle event which workloads must tolerate due to any number of conditions such as eviction policies. Therefore we are removing this risk, we hope that a fix for this defect will be available soon.
We recommend continuing to follow this bug for progress https://issues.redhat.com/browse/OCPBUGS-14605