Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDN-4019: blocked-edges: Declare MultiNetworkAttachmentsWhereaboutsVersion for 4.12.18+ and 4.13 #3794

Conversation

wking
Copy link
Member

@wking wking commented Jun 30, 2023

Generated by writing the 4.12.18 risk by hand, and copying it out with:

$ for Z in 19 20 21 22; do sed "s/4[.]12[.]18/4.12.${Z}/g" blocked-edges/4.12.18-MultiNetworkAttachmentsWhereaboutsVersion.yaml > "blocked-edges/4.12.${Z}-MultiNetworkAttachmentsWhereaboutsVersion.yaml"; done
$ curl -s 'https://api.openshift.com/api/upgrades_info/graph?channel=candidate-4.13' | jq -r '.nodes[].version' | grep '^4[.]13[.]' | while read V; do sed "s/4[.]12[.]18/${V}/g" blocked-edges/4.12.18-MultiNetworkAttachmentsWhereaboutsVersion.yaml > "blocked-edges/${V}-MultiNetworkAttachmentsWhereaboutsVersion.yaml"; done

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2023
@wking wking force-pushed the MultiNetworkAttachmentsWhereaboutsVersion branch from c237c36 to da792e7 Compare June 30, 2023 19:21
@wking wking changed the title blocked-edges: Declare MultiNetworkAttachmentsWhereaboutsVersion for 4.12.18+ and 4.13 SDN-4019: blocked-edges: Declare MultiNetworkAttachmentsWhereaboutsVersion for 4.12.18+ and 4.13 Jun 30, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 30, 2023

@wking: This pull request references SDN-4019 which is a valid jira issue.

In response to this:

Generated by writing the 4.12.18 risk by hand, and copying it out with:

$ for Z in 19 20 21 22; do sed "s/4[.]12[.]18/4.12.${Z}/g" blocked-edges/4.12.18-MultiNetworkAttachmentsWhereaboutsVersion.yaml > "blocked-edges/4.12.${Z}-MultiNetworkAttachmentsWhereaboutsVersion.yaml"; done
$ curl -s 'https://api.openshift.com/api/upgrades_info/graph?channel=candidate-4.13' | jq -r '.nodes[].version' | grep '^4[.]13[.]' | while read V; do sed "s/4[.]12[.]18/${V}/g" blocked-edges/4.12.18-MultiNetworkAttachmentsWhereaboutsVersion.yaml > "blocked-edges/${V}-MultiNetworkAttachmentsWhereaboutsVersion.yaml"; done

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 30, 2023
…4.12.18+ and 4.13

Generated by writing the 4.12.18 risk by hand, and copying it out
with:

  $ for Z in 19 20 21 22; do sed "s/4[.]12[.]18/4.12.${Z}/g" blocked-edges/4.12.18-MultiNetworkAttachmentsWhereaboutsVersion.yaml > "blocked-edges/4.12.${Z}-MultiNetworkAttachmentsWhereaboutsVersion.yaml"; done
  $ curl -s 'https://api.openshift.com/api/upgrades_info/graph?channel=candidate-4.13' | jq -r '.nodes[].version' | grep '^4[.]13[.]' | while read V; do sed "s/4[.]12[.]18/${V}/g" blocked-edges/4.12.18-MultiNetworkAttachmentsWhereaboutsVersion.yaml > "blocked-edges/${V}-MultiNetworkAttachmentsWhereaboutsVersion.yaml"; done
@wking wking force-pushed the MultiNetworkAttachmentsWhereaboutsVersion branch from da792e7 to a129a71 Compare June 30, 2023 19:25
@LalatenduMohanty
Copy link
Member

This seems similar to 999e96d , checking more on this

Copy link
Member

@LalatenduMohanty LalatenduMohanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 3, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LalatenduMohanty, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [LalatenduMohanty,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD a7bdd70 and 2 for PR HEAD a129a71 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 3, 2023

@wking: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit e956f4d into openshift:master Jul 3, 2023
5 checks passed
@wking wking deleted the MultiNetworkAttachmentsWhereaboutsVersion branch July 3, 2023 18:58
wking added a commit to wking/cincinnati-graph-data that referenced this pull request Jul 5, 2023
….23 doesn't have the fix

[1] is still Assigned with the 4.12.z backport.  Generated by
extending the 4.12 sed from a129a71 (blocked-edges: Declare
MultiNetworkAttachmentsWhereaboutsVersion for 4.12.18+ and 4.13,
2023-06-30, openshift#3794):

  $ Z=23; sed "s/4[.]12[.]18/4.12.${Z}/g" blocked-edges/4.12.18-MultiNetworkAttachmentsWhereaboutsVersion.yaml > "blocked-edges/4.12.${Z}-MultiNetworkAttachmentsWhereaboutsVersion.yaml"

[1]: https://issues.redhat.com/browse/OCPBUGS-15588
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
4 participants