Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTA-1000: RHSB2023-001: Add for 4.12.23+ -> 4.13 edges #3887

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

petr-muller
Copy link
Member

@petr-muller petr-muller commented Jul 24, 2023

Created the 4.13.0 file manually, then copied the rest via

$ for x in (seq 1 6)
      cp 4.13.0-RHSB2023001.yaml 4.13.$x-RHSB2023001.yaml
      sed -i "s|4.13.0|4.13.$x|" 4.13.$x-RHSB2023001.yaml 
  end

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: petr-muller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 24, 2023

@petr-muller: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@petr-muller petr-muller changed the title RHSB2023-001: Add for 4.12.23+ -> 4.13 edges OTA-1000: RHSB2023-001: Add for 4.12.23+ -> 4.13 edges Jul 24, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 24, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 24, 2023

@petr-muller: This pull request references OTA-1000 which is a valid jira issue.

In response to this:

Created the 4.13.0 file manually, then copied the rest via

$ for x in (seq 1 6)
     cp 4.13.0-RHSB2023001.yaml 4.13.$x-RHSB2023001.yaml
     sed -i "s|4.13.0|4.13.$x|" 4.13.$x-RHSB2023001.yaml 
 end

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@LalatenduMohanty
Copy link
Member

/hold as we want to merge this after we have an edge with the FIPS fix.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 24, 2023
@petr-muller
Copy link
Member Author

We need to remember to regenerate the PR at that time

@sdodson
Copy link
Member

sdodson commented Aug 9, 2023

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 9, 2023
@sdodson sdodson merged commit dbfe246 into openshift:master Aug 9, 2023
4 of 5 checks passed
@wking
Copy link
Member

wking commented Aug 9, 2023

I've opened #3970 floating follow-ups to catch up through 4.13.8 (which should have all the fixes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
5 participants