Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NE-1376: Set up AWSMintModeWithoutCredentials on 4.13.* ⟶ 4.13.9 #3984

Conversation

petr-muller
Copy link
Member

I do not have an affected cluster at hand but I ran the PromQL on an unaffected AWS cluster and it correctly resolved to 0 so at least that side is good 👍

All information provided by @wking , I am just the messenger :)

/cc @wking @LalatenduMohanty

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 15, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 15, 2023

@petr-muller: This pull request references NE-1376 which is a valid jira issue.

In response to this:

I do not have an affected cluster at hand but I ran the PromQL on an unaffected AWS cluster and it correctly resolved to 0 so at least that side is good 👍

All information provided by @wking , I am just the messenger :)

/cc @wking @LalatenduMohanty

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 15, 2023
Copy link
Member

@wking wking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2023
@wking
Copy link
Member

wking commented Aug 15, 2023

/retitle NE-1376: Set up AWSMintModeWithoutCredentials on 4.13.* ⟶ 4.13.9

@openshift-ci openshift-ci bot changed the title NE-1376: Set up AWSMintModeWithoutCredentials on 4.13.* ⟶ 4.14.9 NE-1376: Set up AWSMintModeWithoutCredentials on 4.13.* ⟶ 4.13.9 Aug 15, 2023
@petr-muller petr-muller force-pushed the 413-AWSMintModeWithoutCredentials branch from 5c74395 to 9476a80 Compare August 15, 2023 17:01
Copy link
Member

@wking wking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: petr-muller, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2023
@openshift-merge-robot openshift-merge-robot merged commit d3240fd into openshift:master Aug 15, 2023
4 of 5 checks passed
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 15, 2023

@petr-muller: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
4 participants