-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NE-1376: Set up AWSMintModeWithoutCredentials on 4.13.* ⟶ 4.13.9 #3984
NE-1376: Set up AWSMintModeWithoutCredentials on 4.13.* ⟶ 4.13.9 #3984
Conversation
@petr-muller: This pull request references NE-1376 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/retitle NE-1376: Set up AWSMintModeWithoutCredentials on 4.13.* ⟶ 4.13.9 |
AWSMintModeWithoutCredentials
on 4.13.* ⟶ 4.14.95c74395
to
9476a80
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: petr-muller, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@petr-muller: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
I do not have an affected cluster at hand but I ran the PromQL on an unaffected AWS cluster and it correctly resolved to 0 so at least that side is good 👍
All information provided by @wking , I am just the messenger :)
/cc @wking @LalatenduMohanty