-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ETCD-511: Set up EtcdBackupMountPointStuck for 4.14.[3-8]->5.15.0 RC0+ edges #4581
ETCD-511: Set up EtcdBackupMountPointStuck for 4.14.[3-8]->5.15.0 RC0+ edges #4581
Conversation
@petr-muller: This pull request references ETCD-511 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.16.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@petr-muller: This pull request references ETCD-511 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
1 similar comment
@petr-muller: This pull request references ETCD-511 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
🤔 |
/label tide/merge-method-squash |
Boo |
f599ecf
to
292e975
Compare
- Affects upgrades from 4.14.[3-8] to 4.15 - May not affect all platforms but give 4.15 is not GA yet setting up `Always` seems like an acceptable big hammer
292e975
to
7520d17
Compare
@petr-muller: This pull request references ETCD-511 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
lgtm :) Thanks Petr! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LalatenduMohanty, petr-muller The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
c36576d
into
openshift:master
…regexp The extra period snuck in with 7520d17 (ETCD-511: Set up EtcdBackupMountPointStuck for ->5.15.0 RC0+ edges, 2024-01-09, openshift#4581), and kept the single-patch-digit source releases from matching.
…regexp The extra period snuck in with 7520d17 (ETCD-511: Set up EtcdBackupMountPointStuck for ->5.15.0 RC0+ edges, 2024-01-09, openshift#4581), and kept the single-patch-digit source releases from matching. With this commit, they start matching: $ hack/show-edges.py --root-version 4.14.8 candidate-4.15 | grep '^4[.]14[.]8 ' 4.14.8 -> 4.14.10 4.14.8 -(risks: AROBrokenDNSMasq)-> 4.14.9 4.14.8 -(risks: EtcdBackupMountPointStuck)-> 4.15.0-rc.1 4.14.8 -(risks: EtcdBackupMountPointStuck)-> 4.15.0-rc.2
Always
seems like an acceptable big hammer