Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ETCD-511: Set up EtcdBackupMountPointStuck for 4.14.[3-8]->5.15.0 RC0+ edges #4581

Merged

Conversation

petr-muller
Copy link
Member

@petr-muller petr-muller commented Jan 9, 2024

  • Affects upgrades from 4.14.[3-8] to 4.15
  • May not affect all platforms but given 4.15 is not GA yet setting up Always seems like an acceptable big hammer

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 9, 2024

@petr-muller: This pull request references ETCD-511 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.16.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 9, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 9, 2024

@petr-muller: This pull request references ETCD-511 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.16.0" version, but no target version was set.

In response to this:

FIXME: Preliminary content, waiting for ETCD-511 to get content

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

1 similar comment
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 9, 2024

@petr-muller: This pull request references ETCD-511 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.16.0" version, but no target version was set.

In response to this:

FIXME: Preliminary content, waiting for ETCD-511 to get content

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2024
@petr-muller
Copy link
Member Author

ValueError: invalid blocked edge blocked-edges/4.15.0-rc.0-EtcdBackupMountPointStuck.yaml: 'NoneType' object has no attribute 'startswith'

🤔

@petr-muller
Copy link
Member Author

/label tide/merge-method-squash

@openshift-ci openshift-ci bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jan 10, 2024
@petr-muller
Copy link
Member Author

petr-muller commented Jan 10, 2024

Not mergeable. Merge type "squash" disallowed by repo settings

Boo

@petr-muller petr-muller removed the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jan 10, 2024
- Affects upgrades from 4.14.[3-8] to 4.15
- May not affect all platforms but give 4.15 is not GA yet setting up
  `Always` seems like an acceptable big hammer
@petr-muller petr-muller changed the title ETCD-511: WIP: Set up EtcdBackupMountPointStuck for ->5.15.0 RC0+ edges ETCD-511: Set up EtcdBackupMountPointStuck for 4.14.[3-8]->5.15.0 RC0+ edges Jan 11, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 11, 2024

@petr-muller: This pull request references ETCD-511 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.16.0" version, but no target version was set.

In response to this:

  • Affects upgrades from 4.14.[3-8] to 4.15
  • May not affect all platforms but give 4.15 is not GA yet setting up Always seems like an acceptable big hammer

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Member

@LalatenduMohanty LalatenduMohanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tjungblu
Copy link

lgtm :) Thanks Petr!

Copy link
Contributor

openshift-ci bot commented Jan 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LalatenduMohanty, petr-muller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [LalatenduMohanty,petr-muller]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 11, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit c36576d into openshift:master Jan 11, 2024
4 of 5 checks passed
@petr-muller petr-muller deleted the EtcdBackupMountPointStuck branch January 12, 2024 13:20
wking added a commit to wking/cincinnati-graph-data that referenced this pull request Jan 19, 2024
…regexp

The extra period snuck in with 7520d17 (ETCD-511: Set up
EtcdBackupMountPointStuck for ->5.15.0 RC0+ edges, 2024-01-09, openshift#4581),
and kept the single-patch-digit source releases from matching.
wking added a commit to wking/cincinnati-graph-data that referenced this pull request Jan 19, 2024
…regexp

The extra period snuck in with 7520d17 (ETCD-511: Set up
EtcdBackupMountPointStuck for ->5.15.0 RC0+ edges, 2024-01-09, openshift#4581),
and kept the single-patch-digit source releases from matching.  With
this commit, they start matching:

  $ hack/show-edges.py --root-version 4.14.8 candidate-4.15 | grep '^4[.]14[.]8 '
  4.14.8 -> 4.14.10
  4.14.8 -(risks: AROBrokenDNSMasq)-> 4.14.9
  4.14.8 -(risks: EtcdBackupMountPointStuck)-> 4.15.0-rc.1
  4.14.8 -(risks: EtcdBackupMountPointStuck)-> 4.15.0-rc.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
4 participants