Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCO-522: blocked-edges/4.15.0-rc.0-GCPMintModeRoleAdmin: Declare risk #4677

Merged

Conversation

wking
Copy link
Member

@wking wking commented Jan 25, 2024

The PromQL logic is pretty similar to 4.13.9-AWSMintModeWithoutCredentials.yaml

The exposure is probably somewhere in the 4.15 ECs or RCs, but I'm naively opening with a blanket 4.14 -> 4.15 to get this out the door. We can refine the threshold later as we pin down exactly when in 4.15 the creds started using custom roles.

Generated by manually writing the 4.15.0-rc.0 risk, and copying out to other 4.15 with:

$ curl -s 'https://api.openshift.com/api/upgrades_info/graph?channel=candidate-4.15&arch=amd64' | jq -r '.nodes[] | .version' | grep '^4[.]15[.]' | grep -v '^4[.]15[.]0-rc[.]0$' | while read VERSION; do sed "s/4.15.0-rc.0/${VERSION}/" blocked-edges/4.15.0-rc.0-GCPMintModeRoleAdmin.yaml > "blocked-edges/${VERSION}-GCPMintModeRoleAdmin.yaml"; done

The PromQL logic is pretty similar to 4.13.9-AWSMintModeWithoutCredentials.yaml

The exposure is probably somewhere in the 4.15 ECs or RCs, but I'm
naively opening with a blanket 4.14 -> 4.15 to get this out the door.
We can refine the threshold later as we pin down exactly when in 4.15
the creds started using custom roles.

Generated by manually writing the 4.15.0-rc.0 risk, and copying out to
other 4.15 with:

  $ curl -s 'https://api.openshift.com/api/upgrades_info/graph?channel=candidate-4.15&arch=amd64' | jq -r '.nodes[] | .version' | grep '^4[.]15[.]' | grep -v '^4[.]15[.]0-rc[.]0$' | while read VERSION; do sed "s/4.15.0-rc.0/${VERSION}/" blocked-edges/4.15.0-rc.0-GCPMintModeRoleAdmin.yaml > "blocked-edges/${VERSION}-GCPMintModeRoleAdmin.yaml"; done
@wking wking changed the title blocked-edges/4.15.0-rc.0-GCPMintModeRoleAdmin: Declare risk CCO-522: blocked-edges/4.15.0-rc.0-GCPMintModeRoleAdmin: Declare risk Jan 25, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 25, 2024

@wking: This pull request references CCO-522 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.16.0" version, but no target version was set.

In response to this:

The PromQL logic is pretty similar to 4.13.9-AWSMintModeWithoutCredentials.yaml

The exposure is probably somewhere in the 4.15 ECs or RCs, but I'm naively opening with a blanket 4.14 -> 4.15 to get this out the door. We can refine the threshold later as we pin down exactly when in 4.15 the creds started using custom roles.

Generated by manually writing the 4.15.0-rc.0 risk, and copying out to other 4.15 with:

$ curl -s 'https://api.openshift.com/api/upgrades_info/graph?channel=candidate-4.15&arch=amd64' | jq -r '.nodes[] | .version' | grep '^4[.]15[.]' | grep -v '^4[.]15[.]0-rc[.]0$' | while read VERSION; do sed "s/4.15.0-rc.0/${VERSION}/" blocked-edges/4.15.0-rc.0-GCPMintModeRoleAdmin.yaml > "blocked-edges/${VERSION}-GCPMintModeRoleAdmin.yaml"; done

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 25, 2024
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 25, 2024
@LalatenduMohanty
Copy link
Member

/hold till @wking confirms the promql works and removes the hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 25, 2024
@wking
Copy link
Member Author

wking commented Jan 25, 2024

GCP credsremoved cluster says it's not exposed:

image

I dunno how credsremoved should be handled, seems like it would be similar to manual-mode, except that you restore your creds pre-update? I'm ignoring them for now.

GCP mint correctly claims exposed:

image

AWS mint correctly claims not-exposed:

image

So that all looks good:

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 25, 2024
Copy link
Member

@LalatenduMohanty LalatenduMohanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 25, 2024
Copy link
Contributor

openshift-ci bot commented Jan 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LalatenduMohanty, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [LalatenduMohanty,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 77155e2 into openshift:master Jan 25, 2024
4 of 5 checks passed
@wking wking deleted the 4.15-GCPMintModeRoleAdmin branch January 25, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
3 participants