-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CCO-522: blocked-edges/4.15.0-rc.0-GCPMintModeRoleAdmin: Declare risk #4677
CCO-522: blocked-edges/4.15.0-rc.0-GCPMintModeRoleAdmin: Declare risk #4677
Conversation
The PromQL logic is pretty similar to 4.13.9-AWSMintModeWithoutCredentials.yaml The exposure is probably somewhere in the 4.15 ECs or RCs, but I'm naively opening with a blanket 4.14 -> 4.15 to get this out the door. We can refine the threshold later as we pin down exactly when in 4.15 the creds started using custom roles. Generated by manually writing the 4.15.0-rc.0 risk, and copying out to other 4.15 with: $ curl -s 'https://api.openshift.com/api/upgrades_info/graph?channel=candidate-4.15&arch=amd64' | jq -r '.nodes[] | .version' | grep '^4[.]15[.]' | grep -v '^4[.]15[.]0-rc[.]0$' | while read VERSION; do sed "s/4.15.0-rc.0/${VERSION}/" blocked-edges/4.15.0-rc.0-GCPMintModeRoleAdmin.yaml > "blocked-edges/${VERSION}-GCPMintModeRoleAdmin.yaml"; done
@wking: This pull request references CCO-522 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/hold till @wking confirms the promql works and removes the hold |
GCP I dunno how GCP AWS So that all looks good: /hold cancel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LalatenduMohanty, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
77155e2
into
openshift:master
The PromQL logic is pretty similar to 4.13.9-AWSMintModeWithoutCredentials.yaml
The exposure is probably somewhere in the 4.15 ECs or RCs, but I'm naively opening with a blanket 4.14 -> 4.15 to get this out the door. We can refine the threshold later as we pin down exactly when in 4.15 the creds started using custom roles.
Generated by manually writing the 4.15.0-rc.0 risk, and copying out to other 4.15 with:
$ curl -s 'https://api.openshift.com/api/upgrades_info/graph?channel=candidate-4.15&arch=amd64' | jq -r '.nodes[] | .version' | grep '^4[.]15[.]' | grep -v '^4[.]15[.]0-rc[.]0$' | while read VERSION; do sed "s/4.15.0-rc.0/${VERSION}/" blocked-edges/4.15.0-rc.0-GCPMintModeRoleAdmin.yaml > "blocked-edges/${VERSION}-GCPMintModeRoleAdmin.yaml"; done