Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IR-461: blocked-edges/4.14.*: Declare ARORegistryImagePreservation #4725

Merged

Conversation

wking
Copy link
Member

@wking wking commented Feb 5, 2024

Generated by hand-writing the 4.14.1 risk and then copying it out to the rest of 4.14:

$ curl -s 'https://api.openshift.com/api/upgrades_info/graph?channel=candidate-4.14&arch=amd64' | jq -r '.nodes[] | .version' | grep '^4[.]14[.]' | grep -v '^4[.]14[.][01]$' | while read VERSION; do sed "s/4.14.1/${VERSION}/" blocked-edges/4.14.1-AzureRegistryImagePreservation.yaml > "blocked-edges/${VERSION}-AzureRegistryImagePreservation.yaml"; done

@wking wking changed the title blocked-edges/4.14.*: Declare AzureRegistryImagePreservation IR-461: blocked-edges/4.14.*: Declare AzureRegistryImagePreservation Feb 5, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 5, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 5, 2024

@wking: This pull request references IR-461 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.16.0" version, but no target version was set.

In response to this:

Generated by hand-writing the 4.14.1 risk and then copying it out to the rest of 4.14:

$ curl -s 'https://api.openshift.com/api/upgrades_info/graph?channel=candidate-4.14&arch=amd64' | jq -r '.nodes[] | .version' | grep '^4[.]14[.]' | grep -v '^4[.]14[.][01]$' | while read VERSION; do sed "s/4.14.1/${VERSION}/" blocked-edges/4.14.1-AzureRegistryImagePreservation.yaml > "blocked-edges/${VERSION}-AzureRegistryImagePreservation.yaml"; done

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Member

@LalatenduMohanty LalatenduMohanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@wking wking force-pushed the AzureRegistryImagePreservation branch from ebeba75 to 043ee97 Compare February 5, 2024 16:51
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 5, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 5, 2024
@wking wking force-pushed the AzureRegistryImagePreservation branch from 043ee97 to 205e231 Compare February 5, 2024 16:53
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 5, 2024
@wking
Copy link
Member Author

wking commented Feb 5, 2024

Testing the PromQL on a GCP cluster, it correctly judges itself not-exposed:

image

Copy link
Member

@LalatenduMohanty LalatenduMohanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@bennerv
Copy link
Contributor

bennerv commented Feb 5, 2024

On an ARO cluster...

image

@sdodson
Copy link
Member

sdodson commented Feb 5, 2024

/hold
Please decide if this is ARO specific and if so update the PR. If this is believed to apply to all Azure clusters then clear the hold.

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Feb 5, 2024
Generated by hand-writing the 4.14.1 risk and then copying it out to
the rest of 4.14:

  $ $ curl -s 'https://api.openshift.com/api/upgrades_info/graph?channel=candidate-4.14&arch=amd64' | jq -r '.nodes[] | .version' | grep '^4[.]14[.]' | grep -v '^4[.]14[.][01]$' | while read VERSION; do sed "s/4.14.1/${VERSI
ON}/" blocked-edges/4.14.1-ARORegistryImagePreservation.yaml > "blocked-edges/${VERSION}-ARORegistryImagePreservation.yaml"; done
@wking wking force-pushed the AzureRegistryImagePreservation branch from 205e231 to c585228 Compare February 5, 2024 17:10
@wking wking changed the title IR-461: blocked-edges/4.14.*: Declare AzureRegistryImagePreservation IR-461: blocked-edges/4.14.*: Declare ARORegistryImagePreservation Feb 5, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 5, 2024
@wking
Copy link
Member Author

wking commented Feb 5, 2024

pivoted to declaring it narrowly for ARO for now.

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 5, 2024
@bennerv
Copy link
Contributor

bennerv commented Feb 5, 2024

Updated promql looks good on ARO.

image

@wking
Copy link
Member Author

wking commented Feb 5, 2024

GCP cluster still correctly not-exposed to the now-ARO PromQL:

image

@bennerv
Copy link
Contributor

bennerv commented Feb 5, 2024

/lgtm

Copy link
Member

@LalatenduMohanty LalatenduMohanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sdodson
Copy link
Member

sdodson commented Feb 5, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 5, 2024
Copy link
Contributor

openshift-ci bot commented Feb 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bennerv, LalatenduMohanty, sdodson, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [LalatenduMohanty,bennerv,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wking
Copy link
Member Author

wking commented Feb 5, 2024

Unrelated Quay hiccup, and I'm confident that this won't break e2e.

/override ci/prow/e2e

Copy link
Contributor

openshift-ci bot commented Feb 5, 2024

@wking: Overrode contexts on behalf of wking: ci/prow/e2e

In response to this:

Unrelated Quay hiccup, and I'm confident that this won't break e2e.

/override ci/prow/e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

openshift-ci bot commented Feb 5, 2024

@wking: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit a184b09 into openshift:master Feb 5, 2024
5 checks passed
@wking wking deleted the AzureRegistryImagePreservation branch February 5, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
5 participants