-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NetPolicyTimeoutsHostNetworkedPodTraffic
: Exclude cloud platforms from exposure
#4762
NetPolicyTimeoutsHostNetworkedPodTraffic
: Exclude cloud platforms from exposure
#4762
Conversation
group(max_over_time(apiserver_storage_objects{resource="networkpolicies.networking.k8s.io"}[1h]) > 0) | ||
or | ||
0 * group(max_over_time(apiserver_storage_objects[1h])) | ||
- type: PromQL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologize for the whitespace - it is coming from an automation which I'm not able to force to zero-indent :P
@petr-muller: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Tested on b03 cluster which does have networkpolicies:
B03 is an AWS cluster so we do not want it to be exposed: I do not have a non-cloud cluster at hand, so I will simulate by simply rewriting one of the |-ed items in the list of platforms to AWS to test the "platform matches and there are network policies" semantics: Finally, test the same thing on b01 cluster that does not have any network policies, expect it to not match (even with modified list of platforms to include AWS):
Test looks good to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: petr-muller, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
NetPolicyTimeoutsHostNetworkedPodTraffic
: Add_id==""
placeholdersNetPolicyTimeoutsHostNetworkedPodTraffic
: Limit exposure to baremetal-ish platforms