-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API-1687: blocked-edges/4.15.0*-EarlyAPICertRotation: Extend to more recent RCs #4841
API-1687: blocked-edges/4.15.0*-EarlyAPICertRotation: Extend to more recent RCs #4841
Conversation
1228def (blocked-edges/4.15.0-rc.0: Declare EarlyAPICertRotation, 2024-01-05, openshift#4578) thought this was fixed in rc.1, but apparently not [1]. Generated with: $ sed -i '/fixedIn/d' blocked-edges/4.15.0-rc.0-EarlyAPICertRotation.yaml $ curl -s 'https://api.openshift.com/api/upgrades_info/graph?channel=candidate-4.15&arch=amd64' | jq -r '.nodes[] | .version' | grep '^4[.]15[.]' | grep -v '^4[.]15[.]0-\(ec\|rc[.]0\)' | while read VERSION; do sed "s/4.15.0-rc.0/${VERSION}/" blocked-edges/4.15.0-rc.0-EarlyAPICertRotation.yaml > "blocked-edges/${VERSION}-EarlyAPICertRotation.yaml"; done [1]: https://issues.redhat.com/browse/API-1687?focusedId=24231419&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-24231419
@wking: This pull request references API-1687 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LalatenduMohanty, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
c6628e8
into
openshift:master
We thought this was fixed in rc.1, but it wasn't, c74c248 (blocked-edges/4.15.0*-EarlyAPICertRotation: Extend to more recent RCs, 2024-02-26, openshift#4841). Then we thought it was fixed in 4.15.2, but it wasn't, b474a45 (blocked-edges/4.15.3-EarlyAPICertRotation: Extend to 4.15.2 and .3, 2024-03-25, openshift#4981). Now we think it's fixed in 4.15.10 [1], wihch contains all three of: * openshift/cluster-kube-apiserver-operator#1662: OCPBUGS-31807: Use RotatedSigningCASecret in update only mode * openshift/cluster-kube-controller-manager-operator#801: OCPBUGS-31807: use RotatedSigningCASecret and RotatedSelfSignedCertKeySecret only in update mode * openshift/kubernetes#1939: OCPBUGS-31807: UPSTREAM: <carry>: allow type mutation for specific secrets [1]: https://amd64.ocp.releases.ci.openshift.org/releasestream/4-stable/release/4.15.10
1228def (#4578) thought this was fixed in rc.1, but apparently not.
Generated with: