Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API-1687: blocked-edges/4.15.0*-EarlyAPICertRotation: Extend to more recent RCs #4841

Merged

Conversation

wking
Copy link
Member

@wking wking commented Feb 26, 2024

1228def (#4578) thought this was fixed in rc.1, but apparently not.

Generated with:

$ sed -i '/fixedIn/d' blocked-edges/4.15.0-rc.0-EarlyAPICertRotation.yaml
$ curl -s 'https://api.openshift.com/api/upgrades_info/graph?channel=candidate-4.15&arch=amd64' | jq -r '.nodes[] | .version' | grep '^4[.]15[.]' | grep -v '^4[.]15[.]0-\(ec\|rc[.]0\)' | while read VERSION; do sed "s/4.15.0-rc.0/${VERSION}/" blocked-edges/4.15.0-rc.0-EarlyAPICertRotation.yaml > "blocked-edges/${VERSION}-EarlyAPICertRotation.yaml"; done

1228def (blocked-edges/4.15.0-rc.0: Declare EarlyAPICertRotation,
2024-01-05, openshift#4578) thought this was fixed in rc.1, but apparently not
[1].

Generated with:

  $ sed -i '/fixedIn/d' blocked-edges/4.15.0-rc.0-EarlyAPICertRotation.yaml
  $ curl -s 'https://api.openshift.com/api/upgrades_info/graph?channel=candidate-4.15&arch=amd64' | jq -r '.nodes[] | .version' | grep '^4[.]15[.]' | grep -v '^4[.]15[.]0-\(ec\|rc[.]0\)' | while read VERSION; do sed "s/4.15.0-rc.0/${VERSION}/" blocked-edges/4.15.0-rc.0-EarlyAPICertRotation.yaml > "blocked-edges/${VERSION}-EarlyAPICertRotation.yaml"; done

[1]: https://issues.redhat.com/browse/API-1687?focusedId=24231419&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-24231419
@wking wking changed the title blocked-edges/4.15.0*-EarlyAPICertRotation: Extend to more recent RCs API-1687: blocked-edges/4.15.0*-EarlyAPICertRotation: Extend to more recent RCs Feb 26, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 26, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 26, 2024

@wking: This pull request references API-1687 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.16.0" version, but no target version was set.

In response to this:

1228def (#4578) thought this was fixed in rc.1, but apparently not.

Generated with:

$ sed -i '/fixedIn/d' blocked-edges/4.15.0-rc.0-EarlyAPICertRotation.yaml
$ curl -s 'https://api.openshift.com/api/upgrades_info/graph?channel=candidate-4.15&arch=amd64' | jq -r '.nodes[] | .version' | grep '^4[.]15[.]' | grep -v '^4[.]15[.]0-\(ec\|rc[.]0\)' | while read VERSION; do sed "s/4.15.0-rc.0/${VERSION}/" blocked-edges/4.15.0-rc.0-EarlyAPICertRotation.yaml > "blocked-edges/${VERSION}-EarlyAPICertRotation.yaml"; done

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 26, 2024
Copy link
Member

@LalatenduMohanty LalatenduMohanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 26, 2024
Copy link
Contributor

openshift-ci bot commented Feb 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LalatenduMohanty, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [LalatenduMohanty,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit c6628e8 into openshift:master Feb 26, 2024
4 of 5 checks passed
@wking wking deleted the extend-EarlyAPICertRotation branch February 26, 2024 21:29
wking added a commit to wking/cincinnati-graph-data that referenced this pull request Apr 19, 2024
We thought this was fixed in rc.1, but it wasn't, c74c248
(blocked-edges/4.15.0*-EarlyAPICertRotation: Extend to more recent
RCs, 2024-02-26, openshift#4841).

Then we thought it was fixed in 4.15.2, but it wasn't, b474a45
(blocked-edges/4.15.3-EarlyAPICertRotation: Extend to 4.15.2 and .3,
2024-03-25, openshift#4981).

Now we think it's fixed in 4.15.10 [1], wihch contains all three of:

* openshift/cluster-kube-apiserver-operator#1662: OCPBUGS-31807: Use RotatedSigningCASecret in update only mode
* openshift/cluster-kube-controller-manager-operator#801: OCPBUGS-31807: use RotatedSigningCASecret and RotatedSelfSignedCertKeySecret only in update mode
* openshift/kubernetes#1939: OCPBUGS-31807: UPSTREAM: <carry>: allow type mutation for specific secrets

[1]: https://amd64.ocp.releases.ci.openshift.org/releasestream/4-stable/release/4.15.10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
3 participants