Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blocked versions due to OCPBUGS-30256 #4892

Closed
wants to merge 1 commit into from

Conversation

pepedocs
Copy link

@pepedocs pepedocs commented Mar 7, 2024

blocked versions due to OCPBUGS-30256

Issue link: https://issues.redhat.com/browse/OCPBUGS-30256

@pepedocs
Copy link
Author

pepedocs commented Mar 7, 2024

/test e2e-latest-cincinnati

Copy link
Contributor

openshift-ci bot commented Mar 7, 2024

@pepedocs: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@LalatenduMohanty
Copy link
Member

LalatenduMohanty commented Mar 7, 2024

/hold Till we link the impact assessment card in the risk. Refer https://github.com/openshift/enhancements/tree/master/enhancements/update/update-blocker-lifecycle for more information.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 7, 2024
Copy link
Member

@LalatenduMohanty LalatenduMohanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not need any conditional risk for a cluster which has already updated to 4.13 , as the risk does not change between 4.13 to 4.14 or 4.14 to 4.15 if the cluster already on that version which has the regression.
So please remove the risk from 4.14.z, 4.15.z versions

@LalatenduMohanty
Copy link
Member

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 8, 2024
@hlipsig
Copy link
Contributor

hlipsig commented Mar 8, 2024

We do not need any conditional risk for a cluster which has already updated to 4.13 , as the risk does not change between 4.13 to 4.14 or 4.14 to 4.15 if the cluster already on that version which has the regression. So please remove the risk from 4.14.z, 4.14.z versions

Disagree. The issue that necessitates the edge occurs when a node reboots, as it would during upgrade. We want to minimize instances of this as SRE has to manually remediate each node.

@@ -0,0 +1,15 @@
to: 4.13.0
from: .*
url: https://issues.redhat.com/browse/OCPBUGS-30256
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update this link to https://issues.redhat.com/browse/OPNET-479 in all the files included in this PR

Copy link
Contributor

openshift-ci bot commented Mar 8, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pepedocs
Once this PR has been reviewed and has the lgtm label, please ask for approval from lalatendumohanty. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@LalatenduMohanty
Copy link
Member

Disagree. The issue that necessitates the edge occurs when a node reboots, as it would during upgrade. We want to minimize instances of this as SRE has to manually remediate each node.

As per the remediation steps we need to delete .link files to fix the issue. So if a cluster has update to 4.13 and the files are deleted, will these files again get created when they update to 4.14.z?

@cblecker
Copy link
Member

cblecker commented Mar 8, 2024

/close
in favour of #4903

@openshift-ci openshift-ci bot closed this Mar 8, 2024
Copy link
Contributor

openshift-ci bot commented Mar 8, 2024

@cblecker: Closed this PR.

In response to this:

/close
in favour of #4903

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants