MCO-1094: blocked-edges: Declare HighNodeStatusReportFrequency #4965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
jira/valid-reference
|
@wking: This pull request references MCO-1094 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
approved
$ hack/show-edges.py fast-4.14 | grep ' 4[.]14[.]14$' | sort -V
4.13.19 -(risks: AWSCustomDomainNodesNotReady, AzureRegistryImagePreservation, HighNodeStatusReportFrequency)-> 4.14.14
4.13.21 -(risks: AWSCustomDomainNodesNotReady, AzureRegistryImagePreservation, HighNodeStatusReportFrequency)-
...
4.13.30 -(risks: AWSCustomDomainNodesNotReady, AzureRegistryImagePreservation, HighNodeStatusReportFrequency)-> 4.14.14
4.13.31 -(risks: AWSCustomDomainNodesNotReady, AzureRegistryImagePreservation, HighNodeStatusReportFrequency)-> 4.14.14
4.13.32 -(risks: AWSCustomDomainNodesNotReady, AzureRegistryImagePreservation, HighNodeStatusReportFrequency)-> 4.14.14
4.13.33 -(risks: AWSCustomDomainNodesNotReady, AzureRegistryImagePreservation)-> 4.14.14
4.13.34 -(risks: AWSCustomDomainNodesNotReady, AzureRegistryImagePreservation)-> 4.14.14
4.13.35 -(risks: AWSCustomDomainNodesNotReady, AzureRegistryImagePreservation)-> 4.14.14
4.14.0 -(risks: HighNodeStatusReportFrequency)-> 4.14.14
...
4.14.9 -(risks: HighNodeStatusReportFrequency)-> 4.14.14
4.14.10 -(risks: HighNodeStatusReportFrequency)-> 4.14.14
4.14.11 -(risks: HighNodeStatusReportFrequency)-> 4.14.14
4.14.12 -> 4.14.14
4.14.13 -> 4.14.14looks good. |
$ hack/show-edges.py fast-4.13 | grep ' 4[.]13[.]34$' | sort -V
4.12.16 -(risks: AcceleratedNetworkingRace, HighNodeStatusReportFrequency)-> 4.13.34
4.12.17 -(risks: AcceleratedNetworkingRace, HighNodeStatusReportFrequency)-> 4.13.34
...
4.12.48 -(risks: AcceleratedNetworkingRace, HighNodeStatusReportFrequency)-> 4.13.34
4.12.49 -(risks: AcceleratedNetworkingRace, HighNodeStatusReportFrequency)-> 4.13.34
4.12.50 -(risks: AcceleratedNetworkingRace)-> 4.13.34
4.13.0 -(risks: HighNodeStatusReportFrequency)-> 4.13.34
4.13.1 -(risks: HighNodeStatusReportFrequency)-> 4.13.34
4.13.2 -(risks: HighNodeStatusReportFrequency)-> 4.13.34
...
4.13.32 -(risks: HighNodeStatusReportFrequency)-> 4.13.34
4.13.33 -> 4.13.34Looks good. |
$ hack/show-edges.py candidate-4.12 | grep ' 4[.]12[.]51$' | sort -V
4.11.11 -(risks: HighNodeStatusReportFrequency, RHELKernelHighLoadIOWait)-> 4.12.51
4.11.12 -(risks: HighNodeStatusReportFrequency, RHELKernelHighLoadIOWait)-> 4.12.51
4.11.13 -(risks: HighNodeStatusReportFrequency, RHELKernelHighLoadIOWait)-> 4.12.51
...
4.11.58 -(risks: HighNodeStatusReportFrequency, RHELKernelHighLoadIOWait)-> 4.12.51
4.12.0 -(risks: HighNodeStatusReportFrequency, RHELKernelHighLoadIOWait)-> 4.12.51
4.12.1 -(risks: HighNodeStatusReportFrequency, RHELKernelHighLoadIOWait)-> 4.12.51
...
4.12.49 -(risks: HighNodeStatusReportFrequency, RHELKernelHighLoadIOWait)-> 4.12.51
4.12.50 -(risks: RHELKernelHighLoadIOWait)-> 4.12.51Also looks good. |
Regressions to 10s occured in: OCPBUGS-15583, 4.15.0 OCPBUGS-28379, 4.14.12 OCPBUGS-29151, 4.13.33 OCPBUGS-29366, 4.12.51 Recovery to 5m occured in: OCPBUGS-29713, 4.16 OCPBUGS-29797, 4.15.2 OCPBUGS-30225, 4.14.16 OCPBUGS-30285, 4.13.37 OCPBUGS-30329, 4.12.53 I don't need to declare risks into 4.15, because 4.15.1 was never added to any channels, and 4.15.0 only has updates from the already-exposed 4.14.14, so updating from there won't make this worse. 4.12.52 was also never added to channels, so it's just 4.12.51 exposed in the 4.12.z.
wking
force-pushed
the
HighNodeStatusReportFrequency
branch
from
6357780
to
96eb5f5
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sdodson, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit e0c7d2d
into
openshift:master
4 of 5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regressions to 10s occured in:
OCPBUGS-15583, 4.15.0
OCPBUGS-28379, 4.14.12
OCPBUGS-29151, 4.13.33
OCPBUGS-29366, 4.12.51
Recovery to 5m occured in:
OCPBUGS-29713, 4.16
OCPBUGS-29797, 4.15.2
OCPBUGS-30225, 4.14.16
OCPBUGS-30285, 4.13.37
OCPBUGS-30329, 4.12.53