Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPCLOUD-2582: blocked-edges/4.16.*: Declare CRIAuthPluginRHEL #5130

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

wking
Copy link
Member

@wking wking commented Apr 19, 2024

Generated by writing the ec.0 risk manually, and copying out to the other candidate 4.16 with:

$ curl -s 'https://api.openshift.com/api/upgrades_info/graph?channel=candidate-4.16&arch=amd64' | jq -r '.nodes[] | .version' | grep '^4[.]16[.]' | grep -v '^4[.]16[.]0-ec[.]0' | while read VERSION; do sed "s/4.16.0-ec.0/${VERSION}/" blocked-edges/4.16.0-ec.0-CRIAuthPluginRHEL.yaml > "blocked-edges/${VERSION}-CRIAuthPluginRHEL.yaml"; done

Generated by writing the ec.0 risk manually, and copying out to the
other candidate 4.16 with:

  $ curl -s 'https://api.openshift.com/api/upgrades_info/graph?channel=candidate-4.16&arch=amd64' | jq -r '.nodes[] | .version' | grep '^4[.]16[.]' | grep -v '^4[.]16[.]0-ec[.]0' | while read VERSION; do sed "s/4.16.0-ec.0/${VERSION}/" blocked-edges/4.16.0-ec.0-CRIAuthPluginRHEL.yaml > "blocked-edges/${VERSION}-CRIAuthPluginRHEL.yaml"; done
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 19, 2024

@wking: This pull request references OCPCLOUD-2582 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.16.0" version, but no target version was set.

In response to this:

Generated by writing the ec.0 risk manually, and copying out to the other candidate 4.16 with:

$ curl -s 'https://api.openshift.com/api/upgrades_info/graph?channel=candidate-4.16&arch=amd64' | jq -r '.nodes[] | .version' | grep '^4[.]16[.]' | grep -v '^4[.]16[.]0-ec[.]0' | while read VERSION; do sed "s/4.16.0-ec.0/${VERSION}/" blocked-edges/4.16.0-ec.0-CRIAuthPluginRHEL.yaml > "blocked-edges/${VERSION}-CRIAuthPluginRHEL.yaml"; done

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 19, 2024
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 19, 2024
@wking
Copy link
Member Author

wking commented Apr 19, 2024

Testing on a GCP cluster with no RHEL nodes, the cluster correctly assesses itself "not exposed":

image

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 19, 2024
Copy link
Contributor

openshift-ci bot commented Apr 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: petr-muller, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Apr 19, 2024

@wking: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 0c8e8e9 into openshift:master Apr 19, 2024
5 checks passed
@wking wking deleted the CRIAuthPluginRHEL branch May 24, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
3 participants