AUTH-517: Declare ServiceAccountsOAuth for cluster with disabled registry

[petr-muller]

PromQL works as expected on enabled capability, disabled capability, and defensively, on clusters that are somehow not aware a capability:

Trevor suggested we pivot to checking the presence of scaled-up image registry deployment:

cluster runs 2 replicas of registry
first is "no such deployment" -> 1
second is "scaled beyond threshold" -> 0
third is "scaled below threshold" -> 1

For production PromQL we just check the threshold is 0, not 2

[openshift-ci-robot]

@petr-muller: This pull request references AUTH-517 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.16.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@petr-muller: This pull request references AUTH-517 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.16.0" version, but no target version was set.

In response to this:

PromQL works as expected on cluster with enabled registry, and defensively, on clusters that are somehow not aware of that capability:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@petr-muller: This pull request references AUTH-517 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.16.0" version, but no target version was set.

In response to this:

PromQL works as expected on cluster with enabled registry, and defensively, on clusters that are somehow not aware of that capability:

I am obtaining a cluster with the capability disabled to test the positive case.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[petr-muller]

/hold

Needs testing, and there is also chance that the impact is lower (tokens that already existed before update maybe continue to work, just ones created post-update would be affected)

[openshift-ci-robot]

@petr-muller: This pull request references AUTH-517 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.16.0" version, but no target version was set.

In response to this:

PromQL works as expected on enabled capability, disabled capability, and defensively, on clusters that are somehow not aware a capability:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[petr-muller]

/hold cancel

[wking]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: petr-muller, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [petr-muller,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@petr-muller: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.