Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-33984: build-suggestions/4.16: Set minor_min to 4.15.17 #5352

Merged
merged 1 commit into from
Jun 6, 2024
Merged

OCPBUGS-33984: build-suggestions/4.16: Set minor_min to 4.15.17 #5352

merged 1 commit into from
Jun 6, 2024

Conversation

wking
Copy link
Member

@wking wking commented Jun 6, 2024

4.15.17 has OCPBUGS-33984, and we want that in front of every admin taking a 4.15 cluster to a supported 4.16 release.

@wking
build-suggestions/4.16: Set minor_min to 4.15.17
f8316da 
[1] has [2], and we want that in front of every admin taking a 4.15
cluster to a supported 4.16 release.

[1]: https://amd64.ocp.releases.ci.openshift.org/releasestream/4-stable/release/4.15.17
[2]: https://issues.redhat.com/browse/OCPBUGS-33984
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 6, 2024
@openshift-ci-robot
Copy link

@wking: This pull request references Jira Issue OCPBUGS-33984, which is invalid:

  • expected the bug to target either version "4.17." or "openshift-4.17.", but it targets "4.15.z" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

4.15.17 has OCPBUGS-33984, and we want that in front of every admin taking a 4.15 cluster to a supported 4.16 release.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@wking wking added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 6, 2024
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 6, 2024
PratikMahajan
PratikMahajan approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@PratikMahajan PratikMahajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 6, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PratikMahajan, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wking
Copy link
Member Author

wking commented Jun 6, 2024

ImageStream import issue, but I'm extremely comfortable with this change.

/override ci/prow/e2e
/override ci/prow/e2e-latest-cincinnati
/override ci/prow/images
/override ci/prow/validate-blocked-edges

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 6, 2024

@wking: Overrode contexts on behalf of wking: ci/prow/e2e, ci/prow/e2e-latest-cincinnati, ci/prow/images, ci/prow/validate-blocked-edges

In response to this:

ImageStream import issue, but I'm extremely comfortable with this change.

/override ci/prow/e2e
/override ci/prow/e2e-latest-cincinnati
/override ci/prow/images
/override ci/prow/validate-blocked-edges

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 6, 2024

@wking: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit edc80fc into openshift:master Jun 6, 2024
5 checks passed
@openshift-ci-robot
Copy link

@wking: Jira Issue OCPBUGS-33984 is in an unrecognized state (ON_QA) and will not be moved to the MODIFIED state.

In response to this:

4.15.17 has OCPBUGS-33984, and we want that in front of every admin taking a 4.15 cluster to a supported 4.16 release.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@wking wking deleted the 4.15.17-floor-for-4.16 branch June 6, 2024 18:52
wking added a commit to wking/cincinnati-graph-data that referenced this pull request Jun 11, 2024
@wking
blocked-edges/4.16.*-FlowControlV1Beta3Migration: Declare new risk
24b6630 
034fa01 (blocked-edges/4.12.*: Declare AWSOldBootImages,
2022-12-14, openshift#2909) explains why we need to look for 4.9-or-earlier
instead of looking for the 4.8-or-earlier condition this risk is
associated with.

I'm also adding _id="" to the queries as a pattern to support
HyperShift and other systems that could query the cluster's data out
of a PromQL engine that stored data for multiple clusters.  More
context in 5cb2e93 (blocked-edges/4.11.*-KeepalivedMulticastSkew:
Explicit _id="", 2023-05-09, openshift#3591).

Fixed in rc.4, because it has the new minor_min from f8316da
(build-suggestions/4.16: Set minor_min to 4.15.17, 2024-06-06, openshift#5352):

  $ oc adm release info quay.io/openshift-release-dev/ocp-release:4.16.0-rc.3-x86_64 | grep Upgrades
    Upgrades: 4.15.11, 4.15.12, 4.15.13, 4.15.14, 4.15.15, 4.15.16, 4.16.0-ec.1, 4.16.0-ec.2, 4.16.0-ec.3, 4.16.0-ec.4, 4.16.0-ec.5, 4.16.0-ec.6, 4.16.0-rc.0, 4.16.0-rc.1, 4.16.0-rc.2
  $ oc adm release info quay.io/openshift-release-dev/ocp-release:4.16.0-rc.4-x86_64 | grep Upgrades
    Upgrades: 4.15.17, 4.16.0-ec.1, 4.16.0-ec.2, 4.16.0-ec.3, 4.16.0-ec.4, 4.16.0-ec.5, 4.16.0-ec.6, 4.16.0-rc.0, 4.16.0-rc.1, 4.16.0-rc.2, 4.16.0-rc.3

and the fix for [1] is in [2].

[1]: https://issues.redhat.com/browse/OCPBUGS-34492
[2]: https://amd64.ocp.releases.ci.openshift.org/releasestream/4-stable/release/4.15.16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PratikMahajan PratikMahajan PratikMahajan approved these changes

@LalatenduMohanty LalatenduMohanty Awaiting requested review from LalatenduMohanty

Assignees

@PratikMahajan PratikMahajan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
3 participants
@wking @openshift-ci-robot @PratikMahajan