build-suggestions/4.7: Raise *_min to 4.y.9999 #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[1], child of 4.8's [2], didn't make it into 4.7.5, so we want to block all edges into 4.7.5 (like we did for 4.7.4 in 26b44c6, blocked-edges/4.7.4: Block all edges into 4.7.4 on vSphere node hostnames, 2021-03-30, openshift#731). Raising the suggestion floors into the distant future will get 4.7.5 built without update suggestions, which will avoid a confusing message about update sources in the generated errata message. [1]: https://bugzilla.redhat.com/show_bug.cgi?id=1943143 [2]: https://bugzilla.redhat.com/show_bug.cgi?id=1942207
openshift-ci-robot
added
the
approved
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vfreex, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Success: $ oc adm release info -o json quay.io/openshift-release-dev/ocp-release:4.7.5-x86_64 | jq .metadata.previous
[]We'll revert or otherwise twiddle once changes land in 4.7.z that would unblock any updates to the next release. |
wking
added a commit
to wking/cincinnati-graph-data
that referenced
this pull request
Apr 2, 2021
This partially reverts commit f190365, openshift#732. The vSphere hostname thing is verified fixed in 4.7 [1]. And the vSphere HW thing [2]. A new-in-4.7.3 OVN thing that we'd been on the fence about blocking on [3] should also be fixed [4]. 4.6.4 will fix an issue with non-control-plane UPI vSphere MachineConfigPools getting stuck if you update to 4.7 while they're churning a 4.6 udpate, so we're setting the 4.6 floor at 4.6.24. Folks on older 4.6 will have to get to at least 4.6.24 to pick up that fix before they can go to 4.7. [1]: https://bugzilla.redhat.com/show_bug.cgi?id=1943143#c4 [2]: https://bugzilla.redhat.com/show_bug.cgi?id=1941246#c6 [3]: https://bugzilla.redhat.com/show_bug.cgi?id=1940498#c12 [4]: https://bugzilla.redhat.com/show_bug.cgi?id=1942702#c1 [5]: https://bugzilla.redhat.com/show_bug.cgi?id=1940585#c18
wking
added a commit
to wking/cincinnati-graph-data
that referenced
this pull request
Apr 2, 2021
This partially reverts commit f190365, openshift#732. The vSphere hostname thing is verified fixed in 4.7 [1]. And the vSphere HW thing [2]. A new-in-4.7.3 OVN thing that we'd been on the fence about blocking on [3] should also be fixed [4]. 4.6.4 will fix an issue with non-control-plane UPI vSphere MachineConfigPools getting stuck if you update to 4.7 while they're churning a 4.6 udpate [5], so we're setting the 4.6 floor at 4.6.24. Folks on older 4.6 will have to get to at least 4.6.24 to pick up that fix before they can go to 4.7. [1]: https://bugzilla.redhat.com/show_bug.cgi?id=1943143#c4 [2]: https://bugzilla.redhat.com/show_bug.cgi?id=1941246#c6 [3]: https://bugzilla.redhat.com/show_bug.cgi?id=1940498#c12 [4]: https://bugzilla.redhat.com/show_bug.cgi?id=1942702#c1 [5]: https://bugzilla.redhat.com/show_bug.cgi?id=1940585#c18
wking
added a commit
to wking/cincinnati-graph-data
that referenced
this pull request
Jun 26, 2021
1dd86a3 (Blocking the edges from 4.7.5 to 4.7.9, 2021-06-25, openshift#891) was a bit too broad. This commit makes two changes: * The bug was an issue with all the early 4.7, up until the fix landed in 4.7.11. So even though 4.7.4 and earlier already had incoming blocks for other bugs, I'd have added comments there too about their exposure to this bug. That also helps set patterns for when we do have targeted edge blocking, so folks considering ignoring our recommendations and doing 4.6 -> 4.7.4, for example, would know they were exposed to all three of the blocker-worthy bugs that are known (so far) to affect that edge. * The fact that this was a 4.6-to-4.7 regression, and not a 4.7.z regression, means that 4.7.4->4.7.5 and such were not increasing your exposure to the issue (much, I guess memory would be tighter while the nodes were rolling). So the contribution of this bug only blocks 4.6->4.7.z (although other blocking bugs in that 4.7.z might impact 4.7->4.7.z). Also, the blocker entry for 4.7.5 is academic, because we cut 4.7.5 with no baked-in incoming edges. More details on that in f190365 (build-suggestions/4.7: Raise *_min to 4.y.9999, 2021-03-30, openshift#732). But adding the explict entry seems easier than having folks wonder why it's not there, so even though that blocker file is effectively a no-op, I'm keeping it around.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rhbz#1943143, child of 4.8's rhbz#1942207, didn't make it into 4.7.5, so we want to block all edges into 4.7.5 (like we did for 4.7.4 in 26b44c6, #731). Raising the suggestion floors into the distant future will get 4.7.5 built without update suggestions, which will avoid a confusing message about update sources in the generated errata message.