document using shorter name for Update Service CR #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PratikMahajan
changed the title
openshift-ci-robot
added
the
do-not-merge/work-in-progress
PratikMahajan
changed the title
LalatenduMohanty
requested changes
Jan 22, 2021
PratikMahajan
force-pushed
the
route-name-too-big
branch
2 times, most recently
from
11985bf
to
e3bb4c0
Compare
PratikMahajan
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
PratikMahajan
force-pushed
the
route-name-too-big
branch
from
e3bb4c0
to
070a7a0
Compare
wking
reviewed
Feb 11, 2021
In case the user creates the Cincinnati CR with a longer name, there might be a case where the route's hostname exceeds 63 chars. This will result in the route not getting created, inturn crashing the operator. Document using a shorter name, less than 64 characters for Cincinnati CR to prevent the issue.
PratikMahajan
force-pushed
the
route-name-too-big
branch
from
070a7a0
to
25a3bff
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: PratikMahajan, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case the user creates the Cincinnati CR with a longer name, there
might be a case where the route's hostname exceeds 63 chars. This will
result in the route not getting created, inturn crashing the operator.
Document using a shorter name for Cincinnati CR to prevent this
issue.