Replace failure crate with anyhow+thiserror #286
Conversation
openshift-ci-robot
added
the
approved
steveej
force-pushed
the
pr/migrate-away-from-failure
branch
from
9c6dc94
to
349868e
Compare
|
CI flake, Images failed to build. /retest |
| @@ -1,4 +1,4 @@ | |||
| use failure::Fallible; | |||
| use anyhow::Result as Fallible; | |||
Failure was [deprecated][0] and suggests anyhow+thiserror to replace itself in dependent projects. [0]: rust-lang-deprecated/failure#347
steveej
force-pushed
the
pr/migrate-away-from-failure
branch
from
349868e
to
b138286
Compare
I was mislead by this message: when in fact it was an unresolved import in the e2e tests which I missed when testing locally. |
| @@ -154,25 +151,27 @@ pub struct Empty; | |||
|
|
|||
| /// Errors that can be returned by the methods in this library | |||
| pub mod errors { | |||
| use commons::prelude_errors::*; | |||
There was a problem hiding this comment.
I have not seen this before. Can you please explain purpose of this?
There was a problem hiding this comment.
Also did not find any pointers in internet e.g. https://doc.rust-lang.org/std/prelude/index.html
There was a problem hiding this comment.
prelude is a naming convention for modules which export commonly used items. AFAIU there's nothing right or wrong about it, and I decided to include errors in the name as this prelude is about error related items only.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, LalatenduMohanty, steveeJ The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Failure was deprecated and suggests anyhow+thiserror to replace
itself in dependent projects.