policy-engine/src/openapiv3: additionalProperties for Node.metadata #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The metadata value is not a string, it is an object whose sub-properties have string values: $ curl -sH Accept:application/json 'https://api.openshift.com/api/upgrades_info/v1/graph?channel=stable-4.6' | jq -S '.nodes[] | select(.version == "4.6.1")' { "metadata": { "description": "", "io.openshift.upgrades.graph.previous.remove_regex": "4\\.5\\.1[45]", "io.openshift.upgrades.graph.release.channels": "candidate-4.6,fast-4.6,stable-4.6", "io.openshift.upgrades.graph.release.manifestref": "sha256:d78292e9730dd387ff6198197c8b0598da340be7678e8e1e4810b557a926c2b9", "url": "https://access.redhat.com/errata/RHBA-2020:4196" }, "payload": "quay.io/openshift-release-dev/ocp-release@sha256:d78292e9730dd387ff6198197c8b0598da340be7678e8e1e4810b557a926c2b9", "version": "4.6.1" } In OpenAPI, that is represented by an additionalProperties object declaring the type of the child values [1,2]. The previous string claim was from the original OpenAPI declaration in d717acc (policy-engine: add OpenAPI content and route, 2019-01-10, #40). [1]: https://github.com/OAI/OpenAPI-Specification/blame/3.0.2/versions/3.0.2.md#L2404-L2421 [2]: https://github.com/OAI/OpenAPI-Specification/blame/3.0.2/versions/3.0.2.md#L2305
openshift-ci-robot
added
the
approved
openshift-ci-robot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LalatenduMohanty, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel LGTM |
openshift-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The metadata value is not a string, it is an object whose sub-properties have string values:
In OpenAPI, that is represented by an
additionalPropertiesobject declaring the type of the child values.The previous string claim was from the original OpenAPI declaration in d717acc (#40).