Improve actuator AZident field validation err msg

Along the same lines as OCPBUGS-16684 changes
openshift · Aug 9, 2023 · 973abf9 · 973abf9
1 parent 0756114
commit 973abf9
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/pkg/azure/actuator.go b/pkg/azure/actuator.go
@@ -557,7 +557,12 @@ func (a *Actuator) syncWorkloadIdentitySecret(
 	}
 	err := validateAzureProviderSpec(azureProviderSpec)
 	if err != nil {
-		return err
+		logger.WithError(err).Error("error determining whether a credentials update is needed")
+		msg := "error validating credentials request Azure AD Workload Identity fields"
+		return &actuatoriface.ActuatorError{
+			ErrReason: minterv1.CredentialsProvisionFailure,
+			Message:   fmt.Sprintf("%v: %v", msg, err),
+		}
 	}
 	op, err := controllerutil.CreateOrPatch(ctx, a.client, secret, func() error {
 		if secret.Labels == nil {