Bug 1750338: improve permissions simulation by adding region info #124
Conversation
openshift-ci-robot
added
do-not-merge/work-in-progress
joelddiaz
force-pushed
the
simulateregion
branch
from
a59421c
to
48db4ef
Compare
|
Looks fine I would just expand on the commit message to clarify what it helps and what it doesn't. I assume adding this information is safe and doesn't require us to do both a simulate call with region, and a call without? |
Right. We're just making the simulation more accurate when compared with the actual calls that we expect will be performed. |
joelddiaz
force-pushed
the
simulateregion
branch
from
48db4ef
to
6bf0651
Compare
|
/lgtm |
openshift-ci-robot
added
lgtm
|
@dgoodwin i defined some test cases to ensure we are using the region as part of our permissions simulations (let me know if you want the commit squashed) |
joelddiaz
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
Commit title is a little generic, lets squash. Thanks! |
Allow providing an aws region to be used when performing the simulations. IAM permissions can be defined in a way where permissions are granted as long as the region is set to some specific region(s). Add region info when simulating permissions testing so that we avoid false failures (ie we claim permission denied when it would actually work with an acceptable region set).
joelddiaz
force-pushed
the
simulateregion
branch
from
ed46488
to
79661cd
Compare
joelddiaz
changed the title
|
/test e2e-aws-upgrade |
|
/test e2e-aws |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgoodwin, joelddiaz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retitle Bug 1750338: improve permissions simulation by adding region info |
openshift-ci-robot
changed the title
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@joelddiaz: This pull request references Bugzilla bug 1750338, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@joelddiaz: All pull requests linked via external trackers have merged. Bugzilla bug 1750338 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.3 |
|
@joelddiaz: new pull request created: #155 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.2 |
|
@joelddiaz: new pull request created: #157 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Allow providing an aws region to be used when performing the simulations.
IAM permissions can be defined in a way where permissions are granted as long as the region is set to some specific region(s). Add region info when simulating permissions testing so that we avoid false failures (ie we claim permission denied when it would actually work with an acceptable region set).