Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exclusion annotation for hosted use case #151

Merged
merged 1 commit into from Jan 13, 2020

Conversation

csrwng
Copy link
Contributor

@csrwng csrwng commented Jan 10, 2020

The annotation was in the wrong resource. It needs to be applied to both the deployment and the prometheus rule.

@csrwng
Copy link
Contributor Author

csrwng commented Jan 10, 2020

@joelddiaz @dgoodwin ptal

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 10, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2020
Copy link
Contributor

@joelddiaz joelddiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@csrwng you want to edit config/manager/deployment.yaml and config/manager/prometheusrule.yaml, then run 'make' to have the generated manifests/05_deployment.yaml look the way you want

@csrwng
Copy link
Contributor Author

csrwng commented Jan 10, 2020

@csrwng you want to edit config/manager/deployment.yaml and config/manager/prometheusrule.yaml, then run 'make' to have the generated manifests/05_deployment.yaml look the way you want

ahh, thx, will do

@csrwng
Copy link
Contributor Author

csrwng commented Jan 10, 2020

@joelddiaz thx, it should be good now

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 10, 2020
Copy link
Contributor

@joelddiaz joelddiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the old annotation in pkg/assets/bindata.go line 461-462 should also be removed

@csrwng
Copy link
Contributor Author

csrwng commented Jan 13, 2020

@joelddiaz thx, I think it should be good now (again :))

Copy link
Contributor

@joelddiaz joelddiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csrwng, joelddiaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit fa06f17 into openshift:master Jan 13, 2020
@csrwng
Copy link
Contributor Author

csrwng commented Feb 10, 2020

/cherry-pick release-4.3

@openshift-cherrypick-robot

@csrwng: new pull request created: #156

In response to this:

/cherry-pick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants