New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix exclusion annotation for hosted use case #151
Fix exclusion annotation for hosted use case #151
Conversation
@joelddiaz @dgoodwin ptal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@csrwng you want to edit config/manager/deployment.yaml and config/manager/prometheusrule.yaml, then run 'make' to have the generated manifests/05_deployment.yaml look the way you want
ahh, thx, will do |
07fc2ff
to
7edf17b
Compare
@joelddiaz thx, it should be good now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the old annotation in pkg/assets/bindata.go line 461-462 should also be removed
7edf17b
to
7695785
Compare
@joelddiaz thx, I think it should be good now (again :)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csrwng, joelddiaz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
/cherry-pick release-4.3 |
@csrwng: new pull request created: #156 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The annotation was in the wrong resource. It needs to be applied to both the deployment and the prometheus rule.