Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1794313: Some cluster operators fail to come up because RHV CA is not trusted by a pod #164

Merged
merged 1 commit into from Mar 10, 2020
Merged

Bug 1794313: Some cluster operators fail to come up because RHV CA is not trusted by a pod #164

merged 1 commit into from Mar 10, 2020

Conversation

rgolangh
Copy link
Contributor

@rgolangh rgolangh commented Mar 9, 2020

@rgolangh
ovirt: Add ca_bundle to ovirt-credentials
3b1372d 
Signed-off-by: Roy Golan <rgolan@redhat.com>
@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Mar 9, 2020
@openshift-ci-robot
Copy link
Contributor

@rgolangh: This pull request references Bugzilla bug 1794313, which is invalid:

  • expected the bug to target the "4.5.0" release, but it targets "4.4.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1794313: Some cluster operators fail to come up because RHV CA is not trusted by a pod

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 9, 2020
@rgolangh rgolangh mentioned this pull request Mar 9, 2020
Merged
@rgolangh
Copy link
Contributor Author

rgolangh commented Mar 9, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 9, 2020
@openshift-ci-robot
Copy link
Contributor

@rgolangh: This pull request references Bugzilla bug 1794313, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

joelddiaz
joelddiaz reviewed Mar 9, 2020
View reviewed changes
Copy link
Contributor

@joelddiaz joelddiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine. Do we wait for openshift/installer#3261 to merge?

@sdodson
Copy link
Member

sdodson commented Mar 10, 2020

/approve
Getting review on installer PR.

@sdodson
Copy link
Member

sdodson commented Mar 10, 2020

/hold
@joelddiaz do you mind lgtm and approving so that we can clear the hold once the installer PR lands?

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 10, 2020
@joelddiaz
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 10, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelddiaz, rgolangh, sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2020
@sdodson
Copy link
Member

sdodson commented Mar 10, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 10, 2020
@openshift-merge-robot openshift-merge-robot merged commit 116d8c6 into openshift:master Mar 10, 2020
@openshift-ci-robot
Copy link
Contributor

@rgolangh: All pull requests linked via external trackers have merged. Bugzilla bug 1794313 has been moved to the MODIFIED state.

In response to this:

Bug 1794313: Some cluster operators fail to come up because RHV CA is not trusted by a pod

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sdodson
Copy link
Member

sdodson commented Mar 10, 2020

/cherrypick release-4.4

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 10, 2020
Merged
@openshift-cherrypick-robot
Copy link

@sdodson: new pull request created: #165

In response to this:

/cherrypick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelddiaz joelddiaz joelddiaz left review comments

@abutcher abutcher Awaiting requested review from abutcher

Assignees

@joelddiaz joelddiaz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@rgolangh @openshift-ci-robot @sdodson @joelddiaz @openshift-cherrypick-robot @openshift-merge-robot