Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add explicit --manifests-dir for render bootstrap #171

Merged
merged 1 commit into from Mar 30, 2020
Merged

add explicit --manifests-dir for render bootstrap #171

merged 1 commit into from Mar 30, 2020

Conversation

joelddiaz
Copy link
Contributor

allow explicitly setting a --manifests-dir where the render process should look for the CCO configmap to determin whether or not to enable CCO during bootstrap.

add explicit --manifests-dir for render bootstrap
5a0d0d3 
allow explicitly setting a --manifests-dir where the render process should look for the CCO configmap to determin whether or not to enable CCO during bootstrap.
@joelddiaz joelddiaz requested a review from dgoodwin March 30, 2020 15:52
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 30, 2020
@dgoodwin
Copy link
Contributor

Can you clarify why we'd add this option and modify the installer, vs just assuming /asset/manifests?

@joelddiaz
Copy link
Contributor Author

Just following how other static pods are initialized that rely on "input" sources.

Some examples:
https://github.com/openshift/installer/blob/master/data/data/bootstrap/files/usr/local/bin/bootkube.sh.template#L131
https://github.com/openshift/installer/blob/master/data/data/bootstrap/files/usr/local/bin/bootkube.sh.template#L211

@dgoodwin
Copy link
Contributor

/lgtm

SOLD!

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgoodwin, joelddiaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 30, 2020
@openshift-merge-robot openshift-merge-robot merged commit 53fdb37 into openshift:master Mar 30, 2020
@joelddiaz joelddiaz mentioned this pull request Mar 30, 2020
Merged
@joelddiaz joelddiaz deleted the disable-cco-round-2 branch June 16, 2020 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgoodwin dgoodwin Awaiting requested review from dgoodwin

@twiest twiest Awaiting requested review from twiest

Assignees

@dgoodwin dgoodwin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@joelddiaz @dgoodwin @openshift-ci-robot @openshift-merge-robot