New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support other Azure cloud environments #192
support other Azure cloud environments #192
Conversation
/hold This is currently vendoring an openshift/api fork until openshift/api#650 merges. |
7fcbae1
to
c6ad0bf
Compare
lgtm once this starts vendoring openshift/api |
Use the Azure cloud environment specified by the `status.platformStatus.azure.cloudName` field of the infrastructure.config.openshift.io resource. See openshift/enhancements#321
Bump to the latest of github.com/openshift/api to pull in the addition of the `status.platformStatus.azure.cloudName` field of the infrastructure.config.openshift.io in order to support other Azure cloud environments. Repalced github.com/jteeuwen/go-bindata with github.com/go-bindata/go-bindata. Manually bumped the following. k8s.io/client-go v0.18.2 sigs.k8s.io/controller-runtime v0.6.0 Changes from openshift/api#650 See openshift/enhancements#321
c6ad0bf
to
f66835e
Compare
/hold cancel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: joelddiaz, staebler The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test e2e-aws-upgrade |
Use the Azure cloud environment specified by the
status.platformStatus.azure.cloudName
field of the infrastructure.config.openshift.io resource.See openshift/enhancements#321