Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support other Azure cloud environments #192

Merged

Conversation

staebler
Copy link
Contributor

Use the Azure cloud environment specified by the status.platformStatus.azure.cloudName field of the infrastructure.config.openshift.io resource.

See openshift/enhancements#321

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 22, 2020
@staebler
Copy link
Contributor Author

/hold

This is currently vendoring an openshift/api fork until openshift/api#650 merges.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 22, 2020
@staebler staebler force-pushed the azure_other_cloud_env branch 2 times, most recently from 7fcbae1 to c6ad0bf Compare May 22, 2020 17:16
@joelddiaz
Copy link
Contributor

lgtm once this starts vendoring openshift/api

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 4, 2020
Use the Azure cloud environment specified by the
`status.platformStatus.azure.cloudName` field of the
infrastructure.config.openshift.io resource.

See openshift/enhancements#321
Bump to the latest of github.com/openshift/api to pull in the
addition of the `status.platformStatus.azure.cloudName`
field of the infrastructure.config.openshift.io in order to
support other Azure cloud environments.

Repalced github.com/jteeuwen/go-bindata with
github.com/go-bindata/go-bindata.

Manually bumped the following.
  k8s.io/client-go v0.18.2
  sigs.k8s.io/controller-runtime v0.6.0

Changes from openshift/api#650

See openshift/enhancements#321
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 15, 2020
@staebler
Copy link
Contributor Author

c6ad0bf...f66835e

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 15, 2020
Copy link
Contributor

@joelddiaz joelddiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 17, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelddiaz, staebler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@joelddiaz
Copy link
Contributor

/test e2e-aws-upgrade

@openshift-merge-robot openshift-merge-robot merged commit 5f36573 into openshift:master Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants