Updated README primarily to cover modes of operation. #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
do-not-merge/work-in-progress
openshift-ci-robot
added
the
approved
|
I haven't yet reviewed this, but as a heads up, there is another outstanding PR that covers part of this #188 |
joelddiaz
reviewed
May 28, 2020
README.md
Outdated
Comment on lines
31
to
42
| Currently the operator supports AWS, GCP, Azure, VMWare, OpenStack and oVirt. | ||
|
|
||
| # Running from source | ||
| ## Admin Credential Locations | ||
|
|
||
| Cloud | Secret | Secret Data Keys | ||
| --- | --- | --- | ||
| AWS | kube-system/aws-creds | aws_access_key_id aws_secret_access_key | ||
| GCP | kube-system/gcp-credentials | service_account.json | ||
| Azure | kube-system/azure-credentials | azure_client_id azure_client_secret azure_subscription_id azure_tenant_id | ||
| OpenStack | kube-system/openstack-credentials | clouds.yaml | ||
| VSphere | kube-system/vsphere-creds | | ||
| oVirt | kube-system/ovirt-credentials | ovirt_url ovirt_username ovirt_password ovirt_cafile ovirt_insecure ovirt_ca_bundle |
There was a problem hiding this comment.
Maybe it's some latent OCD, but can we sort alphabetically?
Primary goal to document the various modes of operation in CCO. Also includes revamped instructions for manual credentials mode, and an overdue pass at removing outdated info.
dgoodwin
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
Updated with review comments, new content, and WIP removed. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgoodwin, joelddiaz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.