Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare for moving to openshift/api #199

Merged

Conversation

joelddiaz
Copy link
Contributor

stop relying on controller-runtime for type registration

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 1, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 1, 2020
@joelddiaz
Copy link
Contributor Author

/test e2e-aws

2 similar comments
@joelddiaz
Copy link
Contributor Author

/test e2e-aws

@joelddiaz
Copy link
Contributor Author

/test e2e-aws

Joel Diaz added 2 commits June 3, 2020 12:11
No longer using controller-runtime scheme package as we prepare for moving to openshift/api
stop relying on controller-runtime for type registration
@joelddiaz joelddiaz changed the title WIP: prepare for moving to openshift/api prepare for moving to openshift/api Jun 3, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 3, 2020
@joelddiaz
Copy link
Contributor Author

/test images

@sjenning
Copy link
Contributor

sjenning commented Jun 4, 2020

/test e2e-aws-upgrade

@sjenning
Copy link
Contributor

sjenning commented Jun 4, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 4, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelddiaz, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit bafbd81 into openshift:master Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants