Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

restore DeepCopy generation #204

Merged
merged 2 commits into from
Jun 25, 2020
Merged

restore DeepCopy generation #204

merged 2 commits into from
Jun 25, 2020

Commits on Jun 25, 2020

  1. vendor k8s.io/code-generator and stretchr/testify/require

    Joel Diaz committed Jun 25, 2020
    Configuration menu
    Copy the full SHA
    581427e View commit details
    Browse the repository at this point in the history

  2. restore generating DeepCopy methods 

    Turns out that converting to rawExtension can be considered an API-breaking change if we were to really use the full flexibility of the rawExtension. So preserve the map[string]map[string]interface{} fields.

New Makefile targets for generating deepcopy.
Scripts for generating/verifying deepcopy.
Mark fields so that we don't try to generate deepcopy methods for those that cannot be generated.
Create manual deepcopy methods for the fields that need it.
Test cases for the manual deep copy implementations.
Didn't previously have test coverage for CredentialsRequests that defined the PolicyConditions to be applied. Write up some test cases to validate the behavior.

As far as the deepcopy scripts:
Rather than always setting up a temp dir so that deepcopy-gen can run in there, see if the repo's directory tree looks like:

src/github.com/openshift/cloud-credential-operator

If the tree looks that way, then just use that as the GOPATH when generating the deepcopy files.

If the tree doesn't look that way, then set up a temp GOPATH directory setup and symlink back to the current repo w/o copying it to the temp dir.
    Joel Diaz committed Jun 25, 2020
    Configuration menu
    Copy the full SHA
    88b8dc7 View commit details
    Browse the repository at this point in the history