Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unify constants #205

Merged
merged 1 commit into from Jun 26, 2020
Merged

unify constants #205

merged 1 commit into from Jun 26, 2020

Conversation

joelddiaz
Copy link
Contributor

bring everything under pkg/operator/constants (except for the list of FailureConditionTypes which will live with where the conditions are defined).

@joelddiaz joelddiaz requested a review from dgoodwin June 10, 2020 13:57
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2020
@joelddiaz
Copy link
Contributor Author

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 10, 2020
@twiest
Copy link

twiest commented Jun 10, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 10, 2020
unify constants
1b384cc 
bring everything under pkg/operator/constants (except for the list of FailureConditionTypes which will live with where the conditions are defined).
@openshift-ci-robot openshift-ci-robot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 17, 2020
@dgoodwin
Copy link
Contributor

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgoodwin, joelddiaz, twiest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dgoodwin,joelddiaz,twiest]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 17, 2020
@joelddiaz
Copy link
Contributor Author

@dgoodwin i don't know when is a good time to bring this in since it will affect so many in-flight PRs

@sjenning how badly would this PR affect what you're working on?

@dgoodwin
Copy link
Contributor

Probably waited long enough, unhold sounds ok to me if it's ok with you.

@joelddiaz
Copy link
Contributor Author

/unhold

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 25, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 20df268 into openshift:master Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgoodwin dgoodwin Awaiting requested review from dgoodwin

@csrwng csrwng Awaiting requested review from csrwng

@twiest twiest Awaiting requested review from twiest

Assignees

@dgoodwin dgoodwin

@twiest twiest

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@joelddiaz @twiest @dgoodwin @openshift-ci-robot @openshift-bot @openshift-merge-robot