Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

annotate CredentialsRequest structs for openshift/api #222

Merged

Conversation

joelddiaz
Copy link
Contributor

These changes make the generated CRD from openshift/api exactly match the current CRD in cloud-credential-operator/manifests/00-crd.yaml

These changes make the generated CRD from openshift/api exactly match the current CRD in cloud-credential-operator/manifests/00-crd.yaml
@joelddiaz joelddiaz requested a review from dgoodwin July 9, 2020 11:34
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 9, 2020
@dgoodwin
Copy link
Contributor

dgoodwin commented Jul 9, 2020

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgoodwin, joelddiaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2020
@openshift-merge-robot openshift-merge-robot merged commit 0296575 into openshift:master Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants