New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1871954: more auto deepcopy functions (less manual) #234
Bug 1871954: more auto deepcopy functions (less manual) #234
Conversation
/test e2e-aws |
/retest |
func deepCopyIAMPolicyCondition(ipc IAMPolicyCondition) IAMPolicyCondition { | ||
cp := make(IAMPolicyCondition) | ||
for key, val := range ipc { | ||
*out = make(IAMPolicyCondition) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*out = make(IAMPolicyCondition) | |
*out = make(IAMPolicyCondition, len(*in)) |
if val != nil { | ||
cp[key] = make(IAMPolicyConditionKeyValue) | ||
tgt[key] = make(IAMPolicyConditionKeyValue) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tgt[key] = make(IAMPolicyConditionKeyValue) | |
tgt[key] = make(IAMPolicyConditionKeyValue, len(val)) |
// unexpected type, this could mean we're not | ||
// doing a deepcopy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the expectation that the value in an IAMPolicyConditionKeyValue will always be a string
or a []string
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Reading through the AWS documentation those were the only values I could see documented, and I also tried making policies with the AWS Web UI tooling, and I was also unable to make anything besides string
and []string
.
and fix up bug around incomplete DeepCopy (where changing the source object would change parts of the copied object). add test cases remove assert library for these tests (not appropriate for openshift/api)
8bd6ce3
to
cbab0ed
Compare
/test e2e-aws-upgrade |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: joelddiaz, staebler The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@joelddiaz: This pull request references Bugzilla bug 1871954, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest Please review the full test history for this PR and help us cut down flakes. |
12 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
@joelddiaz: All pull requests linked via external trackers have merged: Bugzilla bug 1871954 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
and fix up bug around incomplete DeepCopy (where changing the source object would change parts of the copied object).
add test cases
remove assert library for these tests (not appropriate for openshift/api)