allow skipping leader election #257
Conversation
|
/assign @dgoodwin |
openshift-ci-robot
added
the
approved
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgoodwin, joelddiaz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
There was a problem hiding this comment.
Do we need a doc update for this in Developer Instructions?
The docs don't really address running with a debugger (which is the only reason I find this to be useful)... As long as CCO is shut down properly there shouldn't be any unnecessary waiting for leader elections, right? |
Yes, if CCO is shutdown properly there is no waiting :) |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
When hard-stopping a debugging session, the leader election cleanup doesn't get to run. Provide a way to skip all the leader election startup to speed up the development loop.