Remove secret controller refs. #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempted hotloop fix. These controller refs are not namespaced, but link to a controller (the CredentialsRequest) in another namespace. This appeared to work fine for cleanup etc, but I suspect it may be the cause of the post-upgrade hotloop where the controller constantly reconciles and creates, then re-syncs and sees no secret. Instead we will delete the target secrets on CredentialsRequest deletion ourselves.
openshift-ci-robot
added
size/M
|
Attempted fix for: #24 |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csrwng, dgoodwin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
confirmed this fixes #24 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempted hotloop fix. These controller refs are not namespaced, but
link to a controller (the CredentialsRequest) in another namespace. This
appeared to work fine for cleanup etc, but I suspect it may be the cause
of the post-upgrade hotloop where the controller constantly reconciles
and creates, then re-syncs and sees no secret.
Instead we will delete the target secrets on CredentialsRequest deletion
ourselves.