Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1880785: Fix CredentialsRequest missing description in 'oc explain' #270

Merged
merged 1 commit into from Nov 18, 2020
Merged

Bug 1880785: Fix CredentialsRequest missing description in 'oc explain' #270

merged 1 commit into from Nov 18, 2020

Conversation

akhil-rane
Copy link
Contributor

In order to make 'oc explain' work we need to enable field pruning
by setting preserveUnknownFields to false

jira: https://issues.redhat.com/browse/OCPBUGSM-17971

@akhil-rane
Fix CredentialsRequest missing description in 'oc explain'
f47ab8b 
In order to make 'oc explain' work we need to enable field pruning
by setting preserveUnknownFields to false
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Nov 17, 2020
@openshift-ci-robot
Copy link
Contributor

@akhil-rane: This pull request references Bugzilla bug 1880785, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1880785: Fix CredentialsRequest missing description in 'oc explain'

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

joelddiaz
joelddiaz reviewed Nov 17, 2020
View reviewed changes
Copy link
Contributor

@joelddiaz joelddiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 17, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akhil-rane, joelddiaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 17, 2020
@akhil-rane
Copy link
Contributor Author

/test e2e-aws

@akhil-rane
Copy link
Contributor Author

/retest

1 similar comment
@akhil-rane
Copy link
Contributor Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit 2707f92 into openshift:master Nov 18, 2020
@openshift-ci-robot
Copy link
Contributor

@akhil-rane: All pull requests linked via external trackers have merged:

Bugzilla bug 1880785 has been moved to the MODIFIED state.

In response to this:

Bug 1880785: Fix CredentialsRequest missing description in 'oc explain'

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelddiaz joelddiaz joelddiaz left review comments

@staebler staebler Awaiting requested review from staebler

@twiest twiest Awaiting requested review from twiest

Assignees

@joelddiaz joelddiaz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@akhil-rane @openshift-ci-robot @joelddiaz @openshift-merge-robot