Bug 1916868: Check 47 creds backport #287

joelddiaz · 2021-01-15T17:02:56Z

Manual backport of #280

Refactor AWS upgradeable checking so that other platforms can use the logic.

Add new GCP, OpenStack, and vSphere secrets to check/set upgradeable on.

openshift-ci-robot · 2021-01-15T17:02:57Z

@joelddiaz: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2021-01-15T17:04:57Z

@joelddiaz: This pull request references Bugzilla bug 1916868, which is invalid:

expected dependent Bugzilla bug 1916454 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

joelddiaz · 2021-01-15T17:06:24Z

no auto cherry pick, so i can't self LGTM :/

/assign @akhil-rane
/cc @dgoodwin

akhil-rane

/lgtm

openshift-ci-robot · 2021-01-15T17:10:16Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akhil-rane, joelddiaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [joelddiaz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2021-01-16T01:00:24Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-01-16T01:00:28Z

@openshift-bot: This pull request references Bugzilla bug 1916868, which is invalid:

expected dependent Bugzilla bug 1916454 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-01-17T01:00:37Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-01-17T01:00:41Z

@openshift-bot: This pull request references Bugzilla bug 1916868, which is invalid:

expected dependent Bugzilla bug 1916454 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-01-18T01:01:04Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-01-18T01:01:08Z

@openshift-bot: This pull request references Bugzilla bug 1916868, which is invalid:

expected dependent Bugzilla bug 1916454 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-01-19T01:00:47Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-01-19T01:00:51Z

@openshift-bot: This pull request references Bugzilla bug 1916868, which is invalid:

expected dependent Bugzilla bug 1916454 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-01-20T01:01:04Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-01-20T01:01:08Z

@openshift-bot: This pull request references Bugzilla bug 1916868, which is invalid:

expected dependent Bugzilla bug 1916454 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-01-21T01:00:48Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-01-21T01:00:51Z

@openshift-bot: This pull request references Bugzilla bug 1916868, which is invalid:

expected dependent Bugzilla bug 1916454 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-01-22T01:00:29Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-01-22T01:00:33Z

@openshift-bot: This pull request references Bugzilla bug 1916868, which is invalid:

expected dependent Bugzilla bug 1916454 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-01-23T01:00:15Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-01-23T01:00:24Z

@openshift-bot: This pull request references Bugzilla bug 1916868, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.z) matches configured target release for branch (4.6.z)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1916454 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1916454 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0
bug has dependents

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bparees · 2021-02-11T19:08:00Z

pkg/operator/utils/utils.go

+			upgradeableCondition.Status = configv1.ConditionFalse
+			upgradeableCondition.Reason = constants.MissingSecretsForUpgradeReason
+			upgradeableCondition.Message = fmt.Sprintf(
+				"Cannot upgrade manual mode cluster to %s due to missing secret(s): %v Please see Manualy Creating IAM documentation for the cluster's platform.",


Suggested change

"Cannot upgrade manual mode cluster to %s due to missing secret(s): %v Please see Manualy Creating IAM documentation for the cluster's platform.",

"Cannot upgrade manual mode cluster to %s due to missing secret(s): %v Please see Manually Creating IAM documentation for the cluster's platform.",

so that other upgradeable checks can re-use the logic

reorder GCP actuator imports to be more consistent with the rest of the repo fix constants import

reorder imports to be more consistent with the rest of the repo

reorder imports to be more consistent with rest of repo

openshift-ci-robot · 2021-02-11T20:37:38Z

New changes are detected. LGTM label has been removed.

openshift-ci-robot · 2021-02-11T22:28:42Z

@joelddiaz: All pull requests linked via external trackers have merged:

openshift/cloud-credential-operator#287

Bugzilla bug 1916868 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot requested review from csrwng and twiest January 15, 2021 17:03

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 15, 2021

joelddiaz changed the title ~~Check 47 creds backport~~ Bug 1916868: Check 47 creds backport Jan 15, 2021

openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jan 15, 2021

openshift-ci-robot assigned akhil-rane Jan 15, 2021

openshift-ci-robot requested a review from dgoodwin January 15, 2021 17:06

akhil-rane reviewed Jan 15, 2021

View reviewed changes

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2021

twiest removed their request for review January 19, 2021 19:09

openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jan 23, 2021

bparees reviewed Feb 11, 2021

View reviewed changes

Joel Diaz added 4 commits February 11, 2021 15:37

refactor AWS upgradeable check

3283fd7

so that other upgradeable checks can re-use the logic

add new-to-4.7 Secrets to GCP upgradeable check

fdd53ed

reorder GCP actuator imports to be more consistent with the rest of the repo fix constants import

add new-to-4.7 Secrets for vSphere upgradeable check

35fa5d5

reorder imports to be more consistent with the rest of the repo

add new-to-4.7 Secrets for OpenStack upgradeable check

1ed6c3e

reorder imports to be more consistent with rest of repo

joelddiaz force-pushed the check-47-creds-backport branch from 1f9898c to 1ed6c3e Compare February 11, 2021 20:37

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 11, 2021

bparees added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. labels Feb 11, 2021

openshift-merge-robot merged commit d456390 into openshift:release-4.6 Feb 11, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 1916868: Check 47 creds backport #287

Bug 1916868: Check 47 creds backport #287

joelddiaz commented Jan 15, 2021

openshift-ci-robot commented Jan 15, 2021

openshift-ci-robot commented Jan 15, 2021

joelddiaz commented Jan 15, 2021

akhil-rane left a comment

openshift-ci-robot commented Jan 15, 2021

openshift-bot commented Jan 16, 2021

openshift-ci-robot commented Jan 16, 2021

openshift-bot commented Jan 17, 2021

openshift-ci-robot commented Jan 17, 2021

openshift-bot commented Jan 18, 2021

openshift-ci-robot commented Jan 18, 2021

openshift-bot commented Jan 19, 2021

openshift-ci-robot commented Jan 19, 2021

openshift-bot commented Jan 20, 2021

openshift-ci-robot commented Jan 20, 2021

openshift-bot commented Jan 21, 2021

openshift-ci-robot commented Jan 21, 2021

openshift-bot commented Jan 22, 2021

openshift-ci-robot commented Jan 22, 2021

openshift-bot commented Jan 23, 2021

openshift-ci-robot commented Jan 23, 2021

bparees Feb 11, 2021

openshift-ci-robot commented Feb 11, 2021

openshift-ci-robot commented Feb 11, 2021

	"Cannot upgrade manual mode cluster to %s due to missing secret(s): %v Please see Manualy Creating IAM documentation for the cluster's platform.",
	"Cannot upgrade manual mode cluster to %s due to missing secret(s): %v Please see Manually Creating IAM documentation for the cluster's platform.",

Bug 1916868: Check 47 creds backport #287

Bug 1916868: Check 47 creds backport #287

Conversation

joelddiaz commented Jan 15, 2021

openshift-ci-robot commented Jan 15, 2021

openshift-ci-robot commented Jan 15, 2021

joelddiaz commented Jan 15, 2021

akhil-rane left a comment

Choose a reason for hiding this comment

openshift-ci-robot commented Jan 15, 2021

openshift-bot commented Jan 16, 2021

openshift-ci-robot commented Jan 16, 2021

openshift-bot commented Jan 17, 2021

openshift-ci-robot commented Jan 17, 2021

openshift-bot commented Jan 18, 2021

openshift-ci-robot commented Jan 18, 2021

openshift-bot commented Jan 19, 2021

openshift-ci-robot commented Jan 19, 2021

openshift-bot commented Jan 20, 2021

openshift-ci-robot commented Jan 20, 2021

openshift-bot commented Jan 21, 2021

openshift-ci-robot commented Jan 21, 2021

openshift-bot commented Jan 22, 2021

openshift-ci-robot commented Jan 22, 2021

openshift-bot commented Jan 23, 2021

openshift-ci-robot commented Jan 23, 2021

bparees Feb 11, 2021

Choose a reason for hiding this comment

openshift-ci-robot commented Feb 11, 2021

openshift-ci-robot commented Feb 11, 2021