Documentation to add a new cloud provider #326
Conversation
|
/assign @joelddiaz |
docs/adding-new-cloud-provider.md
Outdated
| 4) Implement [this](../pkg/operator/credentialsrequest/actuator/actuator.go) actuator interface. Here you add code to create/update/manage credentials on the cloud. Refer aws implementation [here](../pkg/aws/actuator/actuator.go). | ||
| 5) Add the new actuator to the [controller.go](../pkg/operator/controller.go) | ||
| 6) Add the new platform in `crInfraMatches` function in [credentrialsrequest_controller.go](../pkg/operator/credentialsrequest/credentialsrequest_controller.go) so that it identified as a valid platform by the controller. | ||
| 7) Add the code for [secretannotator_controller.go](../pkg/operator/secretannotator/secretannotator_controller.go) to annotate the cloud credential secret to indicate the credential's capabilities. Refer aws implementation [here](../pkg/operator/secretannotator/aws/reconciler.go). |
There was a problem hiding this comment.
Optionally? I think this is optional b/c we have several platforms that only support Passthrough mode, and they don't have a secret_annotator implementation.
There was a problem hiding this comment.
We do have some platforms (like OpenStack) that only support Passthrough mode and also have secret annotator implementation. Should we just avoid this controller for Passthough only cloud platform? Whats the harm in keeping it just for consistency?
There was a problem hiding this comment.
Let's go ahead an leave it in as we should have the annotator behave as similar as possible across platforms.
akhil-rane
force-pushed
the
document_adding_new_provider
branch
from
da59c87
to
a0cf157
Compare
|
@joelddiaz addressed your feedback |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akhil-rane, joelddiaz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest |
Looks like you could benefit from |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/test e2e-aws-manual-oidc |
|
Since openshift/release#19520 has landed, at some point tide should kick this over to not requiring any of these jobs anymore. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@akhil-rane: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
x-ref: https://issues.redhat.com/browse/CCO-82