New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add permissions boundary support to ccoctl when creating AWS IAM Roles #346
Add permissions boundary support to ccoctl when creating AWS IAM Roles #346
Conversation
Hi @bellpr. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/assign @joelddiaz @dgoodwin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine to me.
@dgoodwin I think the only question I have is whether we want to expose this functionality for the create-all
subcommand.
It's on AWS specific sub-commands, it would be weird if you could only use it if you did step by step and not create-all. Feels like create-all might need some command flag inheritance someday, but as is it looks ok to me. Any reason we'd not want it on create-all I'm not aware of? |
looks okay to me to have this subcommand on |
…es --dry-run` to ensure it is valid input for the `CreateRole`/`PutRolePolicy` APIs and document the requirement Apply role tags in `ccoctl aws create-iam-roles --dry-run` JSON output consistent with the behavior without `--dry-run`
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bellpr, joelddiaz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
Codecov Report
@@ Coverage Diff @@
## master #346 +/- ##
=========================================
Coverage ? 44.82%
=========================================
Files ? 74
Lines ? 6918
Branches ? 0
=========================================
Hits ? 3101
Misses ? 3329
Partials ? 488 Continue to review full report at Codecov.
|
No description provided.