Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build-machinery-go #361

Merged
merged 1 commit into from Jul 7, 2021

Conversation

2uasimojo
Copy link
Member

No description provided.

@openshift-ci openshift-ci bot requested review from csrwng and twiest July 6, 2021 15:46
@2uasimojo
Copy link
Member Author

/hold

The release binary for controller-gen v0.2.5 still reports its version as (devel), so this happens:

[efried@efried cloud-credential-operator]$ make ensure-controller-gen 
Installing controller-gen into '_output/tools/bin/controller-gen'
mkdir -p '_output/tools/bin/'
curl -s -f -L https://github.com/openshift/kubernetes-sigs-controller-tools/releases/download/v0.2.5/controller-gen-linux-amd64 -o '_output/tools/bin/controller-gen'
chmod +x '_output/tools/bin/controller-gen';
[efried@efried cloud-credential-operator]$ make ensure-controller-gen 
Using existing controller-gen from "_output/tools/bin/controller-gen"
Warning: Installed controller-gen version (devel) does not match expected version v0.2.5.

I'm going to get those binaries fixed up, then we can merge this.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 6, 2021
@2uasimojo
Copy link
Member Author

get those binaries fixed up

This is done.

/hold cancel

/assign @joelddiaz

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 6, 2021
@joelddiaz
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 7, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 2uasimojo, joelddiaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2021
@openshift-merge-robot openshift-merge-robot merged commit afe7ddc into openshift:master Jul 7, 2021
@2uasimojo 2uasimojo deleted the update-bmg branch July 7, 2021 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants