Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1990975: Enhance mechanism of reading ibm cloud apikey #365

Merged
merged 1 commit into from Aug 7, 2021
Merged

Bug 1990975: Enhance mechanism of reading ibm cloud apikey #365

merged 1 commit into from Aug 7, 2021

Conversation

mkumatag
Copy link
Member

@mkumatag mkumatag commented Jul 26, 2021 •
edited

Have seen users to use following set of environments to pass the APIKEY, so this PR is to support all those possible environment varaibles.

"IC_API_KEY", "IBMCLOUD_API_KEY", "BM_API_KEY", "BLUEMIX_API_KEY"

@openshift-ci openshift-ci bot requested review from abutcher and dgoodwin July 26, 2021 07:36
@mkumatag
Copy link
Member Author

/cc @BobbyRadford

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 26, 2021

@mkumatag: GitHub didn't allow me to request PR reviews from the following users: BobbyRadford.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @BobbyRadford

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Jul 26, 2021 •
edited

Codecov Report

Merging #365 (e9a2ef9) into master (60a783d) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #365      +/-   ##
==========================================
+ Coverage   46.00%   46.03%   +0.03%     
==========================================
  Files          74       74              
  Lines        7750     7755       +5     
==========================================
+ Hits         3565     3570       +5     
  Misses       3691     3691              
  Partials      494      494
Impacted Files Coverage Δ
...cmd/provisioning/ibmcloud/create_shared_secrets.go 46.51% <100.00%> (+3.30%) ⬆️

@mkumatag
Copy link
Member Author

/test e2e-aws

@mkumatag mkumatag changed the title Enhance mechasim of reading ibm cloud apikey Enhance mechanism of reading ibm cloud apikey Jul 26, 2021
@mkumatag
Copy link
Member Author

/retest

akhil-rane
akhil-rane reviewed Jul 27, 2021
View reviewed changes
pkg/cmd/provisioning/ibmcloud/create_shared_secrets.go Outdated Show resolved Hide resolved
pkg/cmd/provisioning/ibmcloud/create_shared_secrets.go
// APIKeyEnvVar is the environment variable name containing an IBM Cloud API key
const APIKeyEnvVar = "IC_API_KEY"
// APIKeyEnvVars is the environment variable names containing an IBM Cloud API key
var APIKeyEnvVars = []string{"IC_API_KEY", "IBMCLOUD_API_KEY", "BM_API_KEY", "BLUEMIX_API_KEY"}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any kind of precedence criteria here? How ibm cloud cli handles it when all of these environment variables are set?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go-client follows a same approach for reading the token here -
https://github.com/IBM-Cloud/bluemix-go/blob/56edc36e39e52b243c4fb23a2cc63d8296d7d796/session/session.go#L41

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mkumatag lmk what you come up with here. i'm guessing we should be consistent with the installer.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it is missing, we can enhance the code in the installer as well,

akhil-rane
akhil-rane reviewed Jul 27, 2021
View reviewed changes
Copy link
Contributor

@akhil-rane akhil-rane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2021
@joelddiaz
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 5, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akhil-rane, joelddiaz, mkumatag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 5, 2021
@mkumatag
Copy link
Member Author

mkumatag commented Aug 6, 2021

@akhil-rane @joelddiaz it says missing bz label, not sure if there is a way to get rid of this condition!

@akhil-rane
Copy link
Contributor

@akhil-rane @joelddiaz it says missing bz label, not sure if there is a way to get rid of this condition!

I am creating a BZ and linking this PR

@akhil-rane akhil-rane changed the title Enhance mechanism of reading ibm cloud apikey Bug 1990975: Enhance mechanism of reading ibm cloud apikey Aug 6, 2021
@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Aug 6, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 6, 2021

@mkumatag: This pull request references Bugzilla bug 1990975, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @lwan-wanglin

In response to this:

Bug 1990975: Enhance mechanism of reading ibm cloud apikey

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@mkumatag
Copy link
Member Author

mkumatag commented Aug 6, 2021

/retest-required

@mkumatag
Copy link
Member Author

mkumatag commented Aug 7, 2021

/test e2e-upgrade

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci openshift-ci bot merged commit 0d83e9b into openshift:master Aug 7, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 7, 2021

@mkumatag: All pull requests linked via external trackers have merged:

Bugzilla bug 1990975 has been moved to the MODIFIED state.

In response to this:

Bug 1990975: Enhance mechanism of reading ibm cloud apikey

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mkumatag mkumatag deleted the enhance_apikey branch April 30, 2023 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clnperez clnperez clnperez left review comments

@akhil-rane akhil-rane akhil-rane left review comments

@abutcher abutcher Awaiting requested review from abutcher

@dgoodwin dgoodwin Awaiting requested review from dgoodwin

@lwan-wanglin lwan-wanglin Awaiting requested review from lwan-wanglin

Assignees

@akhil-rane akhil-rane

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mkumatag @joelddiaz @akhil-rane @openshift-bot @clnperez