Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.10] OCPBUGS-13847: Determine AWS partition based on region for readOnlyAnonUserPolicyTemplate bucket ARN. #541

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #540

/assign abutcher

@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-13792 has been cloned as Jira Issue OCPBUGS-13847. Will retitle bug to link to clone.
/retitle [release-4.10] OCPBUGS-13847: Determine AWS partition based on region for readOnlyAnonUserPolicyTemplate bucket ARN.

In response to this:

This is an automated cherry-pick of #540

/assign abutcher

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.10] OCPBUGS-13792: Determine AWS partition based on region for readOnlyAnonUserPolicyTemplate bucket ARN. [release-4.10] OCPBUGS-13847: Determine AWS partition based on region for readOnlyAnonUserPolicyTemplate bucket ARN. May 19, 2023
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels May 19, 2023
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-13847, which is invalid:

  • expected dependent Jira Issue OCPBUGS-13792 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #540

/assign abutcher

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label May 19, 2023
@openshift-ci openshift-ci bot requested review from dlom and suhanime May 19, 2023 12:49
@abutcher
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 19, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abutcher, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 19, 2023
@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Merging #541 (b04b363) into release-4.10 (a80bd1b) will decrease coverage by 0.05%.
The diff coverage is 75.00%.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           release-4.10     #541      +/-   ##
================================================
- Coverage         46.00%   45.95%   -0.05%     
================================================
  Files                92       92              
  Lines              9656     9659       +3     
================================================
- Hits               4442     4439       -3     
- Misses             4693     4699       +6     
  Partials            521      521              
Impacted Files Coverage Δ
...g/cmd/provisioning/aws/create_identity_provider.go 56.01% <75.00%> (-1.29%) ⬇️

@abutcher
Copy link
Member

ci/prow/e2e-gcp-manual-oidc failed because CCO is upgradeable=false which is an expected state in "Manual" credentialsMode. openshift/origin#27887 fixed this in 4.14 branches but would need to be backported all the way to 4.10 testing.

ci/prow/e2e-azure-upgrade failure could be possible flake of "[sig-network] pods should successfully create sandboxes by not timing out".

/test ci/prow/e2e-azure-upgrade

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 19, 2023

@abutcher: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test coverage
  • /test e2e-aws
  • /test e2e-upgrade
  • /test images
  • /test unit
  • /test verify
  • /test verify-deps

The following commands are available to trigger optional jobs:

  • /test e2e-aws-manual-oidc
  • /test e2e-azure
  • /test e2e-azure-upgrade
  • /test e2e-gcp
  • /test e2e-gcp-manual-oidc
  • /test e2e-openstack
  • /test e2e-openstack-parallel

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-cloud-credential-operator-release-4.10-coverage
  • pull-ci-openshift-cloud-credential-operator-release-4.10-e2e-aws
  • pull-ci-openshift-cloud-credential-operator-release-4.10-e2e-azure-upgrade
  • pull-ci-openshift-cloud-credential-operator-release-4.10-e2e-gcp-manual-oidc
  • pull-ci-openshift-cloud-credential-operator-release-4.10-e2e-upgrade
  • pull-ci-openshift-cloud-credential-operator-release-4.10-images
  • pull-ci-openshift-cloud-credential-operator-release-4.10-unit
  • pull-ci-openshift-cloud-credential-operator-release-4.10-verify
  • pull-ci-openshift-cloud-credential-operator-release-4.10-verify-deps

In response to this:

ci/prow/e2e-gcp-manual-oidc failed because CCO is upgradeable=false which is an expected state in "Manual" credentialsMode. openshift/origin#27887 fixed this in 4.14 branches but would need to be backported all the way to 4.10 testing.

ci/prow/e2e-azure-upgrade failure could be possible flake of "[sig-network] pods should successfully create sandboxes by not timing out".

/test ci/prow/e2e-azure-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abutcher
Copy link
Member

/test e2e-azure-upgrade

@jianping-shu
Copy link

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 22, 2023
@openshift-ci-robot
Copy link
Contributor

@jianping-shu: This pull request references Jira Issue OCPBUGS-13847, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.10.z) matches configured target version for branch (4.10.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-13792 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-13792 targets the "4.11.z" version, which is one of the valid target versions: 4.11.0, 4.11.z
  • bug has dependents

Requesting review from QA contact:
/cc @jianping-shu

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from jianping-shu May 22, 2023 01:24
@jianping-shu
Copy link

/test e2e-gcp-manual-oidc

@jianping-shu
Copy link

Verified with running "ccoctl aws create-all/delete" on several regions:
region us-east-2
region us-gov-west-1
region cn-north-1

@jianping-shu
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 22, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 22, 2023

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@abutcher
Copy link
Member

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label May 22, 2023
@openshift-merge-robot openshift-merge-robot merged commit cb5054f into openshift:release-4.10 May 22, 2023
10 checks passed
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-13847: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-13847 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #540

/assign abutcher

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants