Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.11] PORTENABLE-526: operator: use a partial metadata watch for Namespaces #550

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #546

/assign stevekuznetsov

We only watch namespaces to react to their creation, and the only
information we need about a namespace is its' name, so we can use a
partial metadata watch to winnow down the size of our cache. Namespaces
don't really store much in spec and status, so this effect is likely to
not be enormous, but every bit helps.

Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 23, 2023

@openshift-cherrypick-robot: An error was encountered cloning bug for cherrypick for bug PORTENABLE-526 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details.

Full error message. request failed. Please analyze the request body for more details. Status code: 400: {"errorMessages":[],"errors":{"customfield_12318341":"Operation value must be a string"}}

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.

In response to this:

This is an automated cherry-pick of #546

/assign stevekuznetsov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 23, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
Once this PR has been reviewed and has the lgtm label, please assign 2uasimojo for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Merging #550 (d0b8a8a) into release-4.11 (7c4c935) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           release-4.11     #550      +/-   ##
================================================
- Coverage         46.15%   46.12%   -0.03%     
================================================
  Files                94       94              
  Lines              9781     9786       +5     
================================================
  Hits               4514     4514              
- Misses             4730     4735       +5     
  Partials            537      537              
Impacted Files Coverage Δ
...redentialsrequest/credentialsrequest_controller.go 53.53% <0.00%> (-0.55%) ⬇️

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 23, 2023

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-upgrade d0b8a8a link false /test e2e-azure-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevekuznetsov
Copy link
Contributor

/close

@openshift-ci openshift-ci bot closed this Jun 23, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 23, 2023

@stevekuznetsov: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants