CCO-392: BUGFIX Allow for Secret to exist in AWS STS case

[bentito]

Update Secret if it exists, or create if it doesn't.

The update part is the fix, wasn't allowing for existing Secrets before, but just creating new ones.

[openshift-ci-robot]

@bentito: This pull request references CCO-392 which is a valid jira issue.

In response to this:

Update Secret if it exists, or create if it doesn't.

The update part is the fix, wasn't allowing for existing Secrets before, but just creating new ones.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[bentito]

/test e2e-aws-manual-oidc

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bentito
Once this PR has been reviewed and has the lgtm label, please assign jstuever for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@bentito: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[codecov]

Codecov Report

Merging #558 (28b1b42) into master (0c629a5) will decrease coverage by 0.02%.
The diff coverage is 60.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #558      +/-   ##
==========================================
- Coverage   47.84%   47.82%   -0.02%     
==========================================
  Files          93       93              
  Lines       11488    11501      +13     
==========================================
+ Hits         5496     5500       +4     
- Misses       5359     5365       +6     
- Partials      633      636       +3     

Impacted Files	Coverage Δ
pkg/aws/actuator/actuator.go	62.51% <60.00%> (-0.49%)	⬇️

[stevekuznetsov]

I have this in #545 - any chance we can hold this?

[stevekuznetsov]

/hold

[bentito]

This is covered in #545. closing.