Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CCO-363: Adding azure identity webhook #559

Merged
merged 1 commit into from Aug 11, 2023
Merged

CCO-363: Adding azure identity webhook #559

merged 1 commit into from Aug 11, 2023

Conversation

tsorya
Copy link
Contributor

@tsorya tsorya commented Jul 6, 2023 •
edited

  1. Change aws pod identity controller to be a generic one
  2. Common files moved to common folder in bindata
  3. Adding azure webhook deployment
  4. Don't add azure webhook in case azure credentials are not added

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 6, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 6, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 11, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 11, 2023
@tsorya tsorya changed the title Draft: Show the idea for different webhook controllers Draft: Adding azure identidy webhook Jul 11, 2023
@tsorya tsorya force-pushed the igal/webhook branch 2 times, most recently from c876d5e to 0948abc Compare July 14, 2023 18:27
@tsorya tsorya changed the title Draft: Adding azure identidy webhook CCO-363: Adding azure identidy webhook Jul 14, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 14, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 14, 2023 •
edited by openshift-ci bot

@tsorya: This pull request references CCO-363 which is a valid jira issue.

In response to this:

Just and idea how to change pod identity controller

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 14, 2023 •
edited by openshift-ci bot

@tsorya: This pull request references CCO-363 which is a valid jira issue.

In response to this:

  1. Chnage aws pod identity controller to be a generic one
  2. Common files moved to common folder in bindata
  3. Adding azure webhook deployment
  4. Don't add azure webhook in case azure credentials are not added

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 14, 2023 •
edited by openshift-ci bot

@tsorya: This pull request references CCO-363 which is a valid jira issue.

In response to this:

  1. Change aws pod identity controller to be a generic one
  2. Common files moved to common folder in bindata
  3. Adding azure webhook deployment
  4. Don't add azure webhook in case azure credentials are not added

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tsorya tsorya marked this pull request as ready for review July 14, 2023 18:29
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 14, 2023
@openshift-ci openshift-ci bot requested review from 2uasimojo and dlom July 14, 2023 18:30
@codecov
Copy link

codecov bot commented Jul 14, 2023 •
edited

Codecov Report

Merging #559 (b2d7006) into master (4031723) will increase coverage by 1.25%.
Report is 6 commits behind head on master.
The diff coverage is 64.84%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #559      +/-   ##
==========================================
+ Coverage   48.10%   49.36%   +1.25%     
==========================================
  Files          94       96       +2     
  Lines       11575    11973     +398     
==========================================
+ Hits         5568     5910     +342     
- Misses       5396     5426      +30     
- Partials      611      637      +26
Files Changed Coverage Δ
...rator/podidentity/podidentitywebhook_controller.go 28.74% <12.50%> (ø)
pkg/operator/podidentity/awspodidentitywebhook.go 80.00% <80.00%> (ø)
pkg/assets/v410_00_assets/bindata.go 46.96% <86.88%> (+3.40%) ⬆️
...kg/operator/podidentity/azurepodidentitywebhook.go 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@tsorya
Copy link
Contributor Author

tsorya commented Jul 16, 2023

/test ?

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 16, 2023

@tsorya: The following commands are available to trigger required jobs:

  • /test coverage
  • /test e2e-aws-ovn
  • /test e2e-upgrade
  • /test images
  • /test unit
  • /test verify
  • /test verify-deps

The following commands are available to trigger optional jobs:

  • /test e2e-aws-manual-oidc
  • /test e2e-azure
  • /test e2e-azure-manual-oidc
  • /test e2e-azure-upgrade
  • /test e2e-gcp
  • /test e2e-gcp-manual-oidc
  • /test e2e-openstack
  • /test e2e-openstack-parallel

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-cloud-credential-operator-master-coverage
  • pull-ci-openshift-cloud-credential-operator-master-e2e-aws-ovn
  • pull-ci-openshift-cloud-credential-operator-master-e2e-upgrade
  • pull-ci-openshift-cloud-credential-operator-master-images
  • pull-ci-openshift-cloud-credential-operator-master-unit
  • pull-ci-openshift-cloud-credential-operator-master-verify
  • pull-ci-openshift-cloud-credential-operator-master-verify-deps

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tsorya
Copy link
Contributor Author

tsorya commented Jul 16, 2023

/test e2e-aws-manual-oidc

@tsorya
Copy link
Contributor Author

tsorya commented Jul 16, 2023

/test e2e-azure-manual-oidc

@abutcher abutcher self-assigned this Jul 18, 2023
@abutcher abutcher changed the title CCO-363: Adding azure identidy webhook CCO-363: Adding azure identity webhook Jul 19, 2023
@abutcher
Copy link
Member

Note that once we have the OSE based azure pod identity webhook image we will set it here alongside the AWS image.

@tsorya
Copy link
Contributor Author

tsorya commented Jul 23, 2023

/test e2e-aws-manual-oidc

@tsorya
Copy link
Contributor Author

tsorya commented Jul 27, 2023

/retest

@tsorya tsorya force-pushed the igal/webhook branch 2 times, most recently from b7be12f to 1081829 Compare August 9, 2023 11:11
@tsorya
Copy link
Contributor Author

tsorya commented Aug 9, 2023

/test e2e-azure-manual-oidc

@tsorya
Copy link
Contributor Author

tsorya commented Aug 9, 2023

/test e2e-aws-manual-oidc

@tsorya tsorya force-pushed the igal/webhook branch 3 times, most recently from 6825547 to fb5a5b7 Compare August 9, 2023 14:30
@tsorya
Copy link
Contributor Author

tsorya commented Aug 9, 2023

/test e2e-azure-manual-oidc

@tsorya
Copy link
Contributor Author

tsorya commented Aug 9, 2023

/test e2e-aws-manual-oidc

@tsorya
Copy link
Contributor Author

tsorya commented Aug 9, 2023

/test e2e-azure-manual-oidc

@tsorya
Copy link
Contributor Author

tsorya commented Aug 9, 2023

/test e2e-aws-manual-oidc

@tsorya
Copy link
Contributor Author

tsorya commented Aug 10, 2023

/retest

@tsorya
Copy link
Contributor Author

tsorya commented Aug 10, 2023

/test e2e-aws-manual-oidc

@tsorya
Copy link
Contributor Author

tsorya commented Aug 10, 2023

/test e2e-azure-manual-oidc

@tsorya
Copy link
Contributor Author

tsorya commented Aug 10, 2023

/retest

@abutcher
Copy link
Member

  • Validated that AWS webhook continues to mutate pods in STS clusters.
  • Validated that Azure webhook can be used following procedure using quick-start.

@abutcher
Copy link
Member

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 10, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abutcher, tsorya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 4031723 and 2 for PR HEAD b2d7006 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD f5b6c10 and 1 for PR HEAD b2d7006 in total

@abutcher
Copy link
Member

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 11, 2023

@tsorya: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit b53516f into openshift:master Aug 11, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevekuznetsov stevekuznetsov stevekuznetsov left review comments

@2uasimojo 2uasimojo Awaiting requested review from 2uasimojo

@dlom dlom Awaiting requested review from dlom

Assignees

@abutcher abutcher

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tsorya @openshift-ci-robot @abutcher @stevekuznetsov @openshift-merge-robot