OCPBUGS-15906: ccoctl azure delete to also delete role assignments

[jstuever]

The ccoctl azure subcommand was previously leaking role assignments. This change ensures all associated roleAssignments are removed prior to deleting the user-assigned managed identities.

[openshift-ci-robot]

@jstuever: This pull request references Jira Issue OCPBUGS-15906, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.0) matches configured target version for branch (4.14.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @huangmingxia

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

The ccoctl azure subcommand was previously leaking role assignments in the specified dnszone-resource-group. This change ensures all associated roleAssignments are removed prior to deleting the user-assigned managed identities.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jstuever]

/test e2e-azure-manual-oidc

[jstuever]

/assign @abutcher

[openshift-ci-robot]

@jstuever: This pull request references Jira Issue OCPBUGS-15906, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.0) matches configured target version for branch (4.14.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @huangmingxia

In response to this:

The ccoctl azure subcommand was previously leaking role assignments. This change ensures all associated roleAssignments are removed prior to deleting the user-assigned managed identities.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[abutcher]

Works in my testing! One comment about the info log for no identities if that could be more specific to the RG not existing. Looks good

[codecov]

Codecov Report

Merging #564 (f83c6b7) into master (acfee1f) will increase coverage by 0.95%.
The diff coverage is 1.61%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #564      +/-   ##
==========================================
+ Coverage   48.00%   48.95%   +0.95%     
==========================================
  Files          93       93              
  Lines       11613    12112     +499     
==========================================
+ Hits         5575     5930     +355     
- Misses       5411     5544     +133     
- Partials      627      638      +11     

Impacted Files	Coverage Δ
pkg/cmd/provisioning/azure/delete.go	0.00% <0.00%> (ø)
...md/provisioning/azure/create_managed_identities.go	60.13% <100.00%> (ø)

... and 8 files with indirect coverage changes

[jstuever]

/test e2e-azure-manual-oidc

[jstuever]

/test e2e-upgrade e2e-aws-ovn e2e-azure-manual-oidc

[abutcher]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abutcher, jstuever

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [abutcher,jstuever]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 51f9ae9 and 2 for PR HEAD f83c6b7 in total

[jstuever]

/test e2e-azure-manual-oidc

[jstuever]

/test e2e-azure-manual-oidc

[jstuever]

/test e2e-azure-manual-oidc

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD fbfc7a5 and 1 for PR HEAD f83c6b7 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 273f8c7 and 0 for PR HEAD f83c6b7 in total

[openshift-ci]

@jstuever: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-azure-manual-oidc	f83c6b7	link	false	/test e2e-azure-manual-oidc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@jstuever: Jira Issue OCPBUGS-15906: All pull requests linked via external trackers have merged:

• openshift/cloud-credential-operator#564

Jira Issue OCPBUGS-15906 has been moved to the MODIFIED state.

In response to this:

The ccoctl azure subcommand was previously leaking role assignments. This change ensures all associated roleAssignments are removed prior to deleting the user-assigned managed identities.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.