Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-16614: *: stop checking for the STS feature gate #579

Conversation

stevekuznetsov
Copy link
Contributor

depends on #578

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jul 24, 2023
@openshift-ci-robot
Copy link
Contributor

@stevekuznetsov: This pull request references Jira Issue OCPBUGS-16614, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @fxierh

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

depends on #578

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Merging #579 (100f11f) into master (1f37b78) will increase coverage by 0.28%.
The diff coverage is 25.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #579      +/-   ##
==========================================
+ Coverage   47.86%   48.15%   +0.28%     
==========================================
  Files          94       94              
  Lines       11617    11543      -74     
==========================================
- Hits         5560     5558       -2     
+ Misses       5444     5377      -67     
+ Partials      613      608       -5     
Files Changed Coverage Δ
pkg/azure/actuator.go 53.70% <ø> (-0.35%) ⬇️
pkg/gcp/actuator/actuator.go 57.47% <ø> (-0.18%) ⬇️
pkg/kubevirt/actuator.go 77.77% <ø> (+1.30%) ⬆️
pkg/openstack/actuator.go 0.00% <ø> (ø)
...g/operator/credentialsrequest/actuator/actuator.go 42.85% <ø> (+3.72%) ⬆️
pkg/operator/platform/platform.go 29.62% <ø> (+18.67%) ⬆️
pkg/ovirt/actuator.go 10.52% <ø> (+0.46%) ⬆️
pkg/vsphere/actuator/actuator.go 53.84% <ø> (-0.47%) ⬇️
pkg/aws/actuator/actuator.go 64.06% <20.00%> (-0.19%) ⬇️
...redentialsrequest/credentialsrequest_controller.go 48.92% <50.00%> (+0.14%) ⬆️

... and 1 file with indirect coverage changes

Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@stevekuznetsov
Copy link
Contributor Author

/retest

@abutcher
Copy link
Member

/test e2e-aws-manual-oidc

@abutcher
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 25, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abutcher, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 25, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 25, 2023

@stevekuznetsov: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit b4d1c3d into openshift:master Jul 25, 2023
10 checks passed
@openshift-ci-robot
Copy link
Contributor

@stevekuznetsov: Jira Issue OCPBUGS-16614: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-16614 has not been moved to the MODIFIED state.

In response to this:

depends on #578

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants