New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPCLOUD-2012: ccoctl: Plumb credreq.spec.cloudTokenPath override into Azure secret creation #580
OCPCLOUD-2012: ccoctl: Plumb credreq.spec.cloudTokenPath override into Azure secret creation #580
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #580 +/- ##
==========================================
+ Coverage 47.86% 47.93% +0.07%
==========================================
Files 94 94
Lines 11617 11601 -16
==========================================
+ Hits 5560 5561 +1
+ Misses 5444 5432 -12
+ Partials 613 608 -5
|
6113dc4
to
8d1451b
Compare
8d1451b
to
213e138
Compare
@abutcher: This pull request references OCPCLOUD-2012 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign |
/test e2e-azure-manual-oidc |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abutcher, jstuever The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
/retest |
@abutcher: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Might be needed for overriding the token path as generated by
make assets
for the CAPI operator openshift/cluster-capi-operator#124