Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPCLOUD-2012: ccoctl: Plumb credreq.spec.cloudTokenPath override into Azure secret creation #580

Merged
merged 2 commits into from Jul 27, 2023

Conversation

abutcher
Copy link
Member

Might be needed for overriding the token path as generated by make assets for the CAPI operator openshift/cluster-capi-operator#124

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 25, 2023
@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #580 (213e138) into master (de95fe7) will increase coverage by 0.07%.
Report is 6 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #580      +/-   ##
==========================================
+ Coverage   47.86%   47.93%   +0.07%     
==========================================
  Files          94       94              
  Lines       11617    11601      -16     
==========================================
+ Hits         5560     5561       +1     
+ Misses       5444     5432      -12     
+ Partials      613      608       -5     
Files Changed Coverage Δ
pkg/assets/bootstrap/bindata.go 23.85% <ø> (ø)
...md/provisioning/azure/create_managed_identities.go 57.62% <100.00%> (-2.69%) ⬇️

... and 12 files with indirect coverage changes

@abutcher abutcher changed the title ccoctl: Plumb credreq.spec.cloudTokenPath override into Azure secret creation OCPCLOUD-2012: ccoctl: Plumb credreq.spec.cloudTokenPath override into Azure secret creation Jul 26, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 26, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 26, 2023

@abutcher: This pull request references OCPCLOUD-2012 which is a valid jira issue.

In response to this:

Might be needed for overriding the token path as generated by make assets for the CAPI operator openshift/cluster-capi-operator#124

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jstuever
Copy link
Contributor

/assign

@jstuever
Copy link
Contributor

/test e2e-azure-manual-oidc

@jstuever
Copy link
Contributor

/lgtm
/hold
for e2e-azure-manual-oidc

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Jul 26, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abutcher, jstuever

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jstuever
Copy link
Contributor

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 27, 2023
@jstuever
Copy link
Contributor

/retest

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 0e376e4 and 2 for PR HEAD 213e138 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 27, 2023

@abutcher: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 859de53 into openshift:master Jul 27, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants