OCPBUGS-16807: ccoctl azure exit with error when OIDC and installation resource group names are the same

[abutcher]

ccoctl should provide an error when installation and OIDC resource group names are the same to prevent ccoctl from creating resources in the resource group meant to be used for cluster install. The OpenShift installer requires that the resource group in the install-config.yaml be empty when running the installation.

[openshift-ci-robot]

@abutcher: This pull request references Jira Issue OCPBUGS-16807, which is invalid:

• expected the bug to target the "4.14.0" version, but it targets "4.14" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

ccoctl should provide an error when installation and OIDC resource group names are the same to prevent ccoctl from creating resources in the resource group meant to be used for cluster install. The OpenShift installer requires that the resource group in the install-config.yaml be empty when running the installation.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[abutcher]

/jira refresh

[openshift-ci-robot]

@abutcher: This pull request references Jira Issue OCPBUGS-16807, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.0) matches configured target version for branch (4.14.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jianping-shu

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov]

Codecov Report

Merging #582 (fca7408) into master (b4d1c3d) will decrease coverage by 0.03%.
Report is 2 commits behind head on master.
The diff coverage is 0.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #582      +/-   ##
==========================================
- Coverage   48.15%   48.12%   -0.03%     
==========================================
  Files          94       94              
  Lines       11543    11549       +6     
==========================================
  Hits         5558     5558              
- Misses       5377     5383       +6     
  Partials      608      608              

Files Changed	Coverage Δ
pkg/cmd/provisioning/azure/create_all.go	0.00% <0.00%> (ø)
...md/provisioning/azure/create_managed_identities.go	60.04% <0.00%> (-0.27%)	⬇️

[abutcher]

/assign @jstuever

[jstuever]

/test e2e-azure-manual-oidc

[jstuever]

/lgtm
/hold
for e2e-azure-manual-oidc

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abutcher, jstuever

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [abutcher,jstuever]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jstuever]

/hold cancel

[jstuever]

/retest

[openshift-ci]

@abutcher: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@abutcher: Jira Issue OCPBUGS-16807: All pull requests linked via external trackers have merged:

• openshift/cloud-credential-operator#582

Jira Issue OCPBUGS-16807 has been moved to the MODIFIED state.

In response to this:

ccoctl should provide an error when installation and OIDC resource group names are the same to prevent ccoctl from creating resources in the resource group meant to be used for cluster install. The OpenShift installer requires that the resource group in the install-config.yaml be empty when running the installation.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.